From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
He Kuang <hekuang@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Kaixu Xia <xiakaixu@huawei.com>, Zefan Li <lizefan@huawei.com>
Subject: Re: [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table
Date: Thu, 21 Jan 2016 12:38:48 -0300 [thread overview]
Message-ID: <20160121153848.GD4034@kernel.org> (raw)
In-Reply-To: <56A061D8.80502@huawei.com>
Em Thu, Jan 21, 2016 at 12:43:04PM +0800, Wangnan (F) escreveu:
> I think this problem is not introduced by my patch. In fact
> there's a fundamental problem in get_arch_regstr() that it is
> impossible to switch sub ISA.
> Not only x86_64 and x86_32, I think on arm64 we also have this
> problem when we try to setup uprobes on arm32 code. For me the
> later problem is more important because there are many legacy arm32
> applications on Android platform (and I have already seen the buggy
> unwind result in this case. It is another problem though).
Humm, and possibly to do something with arm code on a x86 workstation,
even if just analysis, yeah, I think these functions should take as an
argument the desired architecture instead of assuming it is the one in
the machine issuing the commands.
> So I suggest us to solve this problem first before considering
> gcc 6 Werror. At least x86_32_regoffset_table and x86_64_regoffset_table
> should both be compiled no matter which ISA we select for perf.
>
> Thank you.
next prev parent reply other threads:[~2016-01-21 15:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 21:32 [PATCH perf 0/4] Build fixes for gcc 6 Ben Hutchings
2016-01-19 21:32 ` [PATCH perf 1/4] perf tools: Fix wrong indentation and build failure with " Ben Hutchings
2016-01-19 21:32 ` [PATCH perf 2/4] perf top: Fix behaviour of Shift-Tab in annotated view with nothing focussed Ben Hutchings
2016-01-19 21:33 ` [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table Ben Hutchings
2016-01-20 13:59 ` Arnaldo Carvalho de Melo
2016-01-21 4:43 ` Wangnan (F)
2016-01-21 15:38 ` Arnaldo Carvalho de Melo [this message]
2016-01-21 15:41 ` Arnaldo Carvalho de Melo
2016-01-22 1:26 ` Wangnan (F)
2016-01-22 5:56 ` 平松雅巳 / HIRAMATU，MASAMI
2016-01-22 6:19 ` Wangnan (F)
2016-01-22 7:59 ` 平松雅巳 / HIRAMATU，MASAMI
2016-01-19 21:33 ` [PATCH perf 4/4] perf tests: Delete mis-indented dead code that causes build failure with gcc 6 Ben Hutchings
2016-01-19 21:40 ` [PATCH perf 0/4] Build fixes for " Markus Trippelsdorf
2016-01-19 21:58 ` Ben Hutchings
2016-01-19 22:00 ` Markus Trippelsdorf
2016-01-19 22:04 ` Ben Hutchings
2016-01-19 22:28 ` Arnaldo Carvalho de Melo
2016-01-19 22:30 ` Arnaldo Carvalho de Melo
2016-01-19 22:43 ` Markus Trippelsdorf
2016-01-19 22:31 ` Markus Trippelsdorf
2016-01-20 13:20 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121153848.GD4034@kernel.org \
--to=acme@kernel.org \
--cc=ben@decadent.org.uk \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).