From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-nvdimm@ml01.01.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, "Lee, Chun-Yi" <jlee@suse.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string
Date: Thu, 21 Jan 2016 09:08:41 -0700 [thread overview]
Message-ID: <20160121160841.GA625@linux.intel.com> (raw)
In-Reply-To: <1453379530-21727-1-git-send-email-jlee@suse.com>
On Thu, Jan 21, 2016 at 08:32:10PM +0800, Lee, Chun-Yi wrote:
> It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
> coded string.
>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> drivers/acpi/nfit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
> index aa45d48..9fb1a6a 100644
> --- a/drivers/acpi/nfit.c
> +++ b/drivers/acpi/nfit.c
> @@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
> acpi_size sz;
> int rc;
>
> - status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
> + status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
> if (ACPI_FAILURE(status)) {
> /* This is ok, we could have an nvdimm hotplugged later */
> dev_dbg(dev, "failed to find NFIT at startup\n");
> --
> 2.1.4
>
prev parent reply other threads:[~2016-01-21 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 12:32 [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string Lee, Chun-Yi
2016-01-21 16:08 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121160841.GA625@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=jlee@suse.com \
--cc=joeyli.kernel@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).