From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965515AbcAUQJd (ORCPT ); Thu, 21 Jan 2016 11:09:33 -0500 Received: from mga03.intel.com ([134.134.136.65]:29918 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964802AbcAUQJa (ORCPT ); Thu, 21 Jan 2016 11:09:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,326,1449561600"; d="scan'208";a="886342616" Date: Thu, 21 Jan 2016 09:08:41 -0700 From: Ross Zwisler To: "Lee, Chun-Yi" Cc: "Rafael J. Wysocki" , linux-nvdimm@ml01.01.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee, Chun-Yi" , Ross Zwisler , Len Brown Subject: Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string Message-ID: <20160121160841.GA625@linux.intel.com> References: <1453379530-21727-1-git-send-email-jlee@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453379530-21727-1-git-send-email-jlee@suse.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2016 at 08:32:10PM +0800, Lee, Chun-Yi wrote: > It's minor but that's still better to use ACPI_SIG_NFIT instead of hard > coded string. > > Cc: Ross Zwisler > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Signed-off-by: Lee, Chun-Yi Acked-by: Ross Zwisler > drivers/acpi/nfit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c > index aa45d48..9fb1a6a 100644 > --- a/drivers/acpi/nfit.c > +++ b/drivers/acpi/nfit.c > @@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev) > acpi_size sz; > int rc; > > - status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz); > + status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz); > if (ACPI_FAILURE(status)) { > /* This is ok, we could have an nvdimm hotplugged later */ > dev_dbg(dev, "failed to find NFIT at startup\n"); > -- > 2.1.4 >