From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965482AbcAUQTz (ORCPT ); Thu, 21 Jan 2016 11:19:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49011 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbcAUQTx (ORCPT ); Thu, 21 Jan 2016 11:19:53 -0500 Date: Thu, 21 Jan 2016 17:19:50 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Feng Wu Cc: pbonzini@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v3 1/4] KVM: Recover IRTE to remapped mode if the interrupt is not single-destination Message-ID: <20160121161949.GA14104@potion.brq.redhat.com> References: <1453254177-103002-1-git-send-email-feng.wu@intel.com> <1453254177-103002-2-git-send-email-feng.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453254177-103002-2-git-send-email-feng.wu@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-01-20 09:42+0800, Feng Wu: > When the interrupt is not single destination any more, we need > to change back IRTE to remapped mode explicitly. > > Signed-off-by: Feng Wu > --- > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > @@ -10764,8 +10764,17 @@ static int vmx_update_pi_irte(struct kvm *kvm, unsigned int host_irq, > - if (!kvm_intr_is_single_vcpu(kvm, &irq, &vcpu)) > + if (!kvm_intr_is_single_vcpu(kvm, &irq, &vcpu)) { > + /* > + * Make sure the IRTE is in remapped mode if > + * we don't handle it in posted mode. > + */ > + pi_set_sn(vcpu_to_pi_desc(vcpu)); What could go wrong if we didn't suppress notifications here? Thanks. > + ret = irq_set_vcpu_affinity(host_irq, NULL); > + pi_clear_sn(vcpu_to_pi_desc(vcpu)); > + > continue; > + }