From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965559AbcAUTEO (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Jan 2016 14:04:14 -0500
Received: from mail.skyhub.de ([78.46.96.112]:58328 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S965495AbcAUTEI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Jan 2016 14:04:08 -0500
Date: Thu, 21 Jan 2016 20:03:40 +0100
From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andy Lutomirski <luto@amacapital.net>, Brian Gerst <brgerst@gmail.com>,
        X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_*
Message-ID: <20160121190340.GG21930@pd.tnic>
References: <1453401286-26966-1-git-send-email-bp@alien8.de>
 <1453401286-26966-2-git-send-email-bp@alien8.de>
 <56A12A02.60607@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <56A12A02.60607@zytor.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 21, 2016 at 10:57:06AM -0800, H. Peter Anvin wrote:
> On 01/21/16 10:34, Borislav Petkov wrote:
> > +#ifndef _ASM_X86_REQUIRED_FEATURES_H
>
> Why do we have all these include guards at the point of the #include?
> This is not standard procedure.

Some uapi monkey business:

abbf1590de22 ("UAPI: Partition the header include path sets and add uapi/ header directories")

The funny thing is, the headers themselves have the guards too. I'll try
to remove them to see what breaks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.