From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbcAUT3c (ORCPT ); Thu, 21 Jan 2016 14:29:32 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36684 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbcAUT33 (ORCPT ); Thu, 21 Jan 2016 14:29:29 -0500 Date: Thu, 21 Jan 2016 11:29:24 -0800 From: Dmitry Torokhov To: Oreste Salerno Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, fery@cypress.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations Message-ID: <20160121192924.GB39970@dtor-ws> References: <20e9f0188f07fc420912b3defa747303be3cf290.1453403916.git.oreste.salerno@tomtom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20e9f0188f07fc420912b3defa747303be3cf290.1453403916.git.oreste.salerno@tomtom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Oreste, On Thu, Jan 21, 2016 at 08:21:13PM +0100, Oreste Salerno wrote: > Use devm_() functions for allocating memory, input device and IRQ. > ... > @@ -625,11 +620,8 @@ EXPORT_SYMBOL_GPL(cyttsp_probe); > > void cyttsp_remove(struct cyttsp *ts) > { > - free_irq(ts->irq, ts); > - input_unregister_device(ts->input); > if (ts->pdata->exit) > ts->pdata->exit(); > - kfree(ts); This is not quite correct as it changes the operations order... Given that it is going to be removed in the next patch I guess it is OK, but ideally you can add a custom devm action to shut off the chip. Thanks. -- Dmitry