From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matt Ranostay <mranostay@gmail.com>
Cc: "Gujulan Elango, Hari Prasath (H.)" <hgujulan@visteon.com>,
"daniel.baluta@intel.com" <daniel.baluta@intel.com>,
"ciorneiioana@gmail.com" <ciorneiioana@gmail.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"hamohammed.sa@gmail.com" <hamohammed.sa@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"jic23@kernel.org" <jic23@kernel.org>
Subject: Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()
Date: Thu, 21 Jan 2016 22:46:51 +0300 [thread overview]
Message-ID: <20160121194651.GA5325@mwanda> (raw)
In-Reply-To: <CAKzfze_t39zoDv16ng04NpVLW1PG3n5WtCnvVp=Amh4EKme2FA@mail.gmail.com>
On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote:
> > @@ -356,8 +356,6 @@ static int spear_adc_probe(struct platform_device *pdev)
> >
> > errout3:
> > clk_disable_unprepare(st->clk);
>
> Shouldn't errout3 now be errout2.. having a gap would seem odd.
>
> > -errout2:
> > - clk_put(st->clk);
> > errout1:
> > iounmap(st->adc_base_spear6xx);
GW-BASIC style numbered gotos are nonsense. Label names should be name
after what the label does.
err_unprepare:
err_put:
err_iounmap:
But that's something for a different patch, not related to this patch.
regards,
dan carpenter
next prev parent reply other threads:[~2016-01-21 19:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 9:11 [PATCH] staging: iio: replace clk_get() with devm_clk_get() Gujulan Elango, Hari Prasath (H.)
2016-01-21 9:45 ` Dan Carpenter
2016-01-21 9:53 ` Gujulan Elango, Hari Prasath (H.)
2016-01-21 19:21 ` Matt Ranostay
2016-01-21 19:46 ` Dan Carpenter [this message]
2016-01-22 7:31 ` Gujulan Elango, Hari Prasath (H.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121194651.GA5325@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ciorneiioana@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=hgujulan@visteon.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox