* [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on
@ 2016-01-21 11:48 Gustavo Padovan
2016-01-21 19:58 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo Padovan @ 2016-01-21 11:48 UTC (permalink / raw)
To: gregkh; +Cc: Gustavo Padovan, Steven Rostedt, Ingo Molnar, open list
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
timeline was wrongly assigned with ->get_driver_name().
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
include/trace/events/fence.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h
index 98feb1b..d6dfa05 100644
--- a/include/trace/events/fence.h
+++ b/include/trace/events/fence.h
@@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on,
TP_STRUCT__entry(
__string(driver, fence->ops->get_driver_name(fence))
- __string(timeline, fence->ops->get_driver_name(fence))
+ __string(timeline, fence->ops->get_timeline_name(fence))
__field(unsigned int, context)
__field(unsigned int, seqno)
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on
2016-01-21 11:48 [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on Gustavo Padovan
@ 2016-01-21 19:58 ` Greg KH
2016-01-21 20:09 ` Gustavo Padovan
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2016-01-21 19:58 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: Gustavo Padovan, Steven Rostedt, Ingo Molnar, open list
On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> timeline was wrongly assigned with ->get_driver_name().
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
> include/trace/events/fence.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h
> index 98feb1b..d6dfa05 100644
> --- a/include/trace/events/fence.h
> +++ b/include/trace/events/fence.h
> @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on,
>
> TP_STRUCT__entry(
> __string(driver, fence->ops->get_driver_name(fence))
> - __string(timeline, fence->ops->get_driver_name(fence))
> + __string(timeline, fence->ops->get_timeline_name(fence))
> __field(unsigned int, context)
> __field(unsigned int, seqno)
Why would you send this to: me? I am not the trace maintainer...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on
2016-01-21 19:58 ` Greg KH
@ 2016-01-21 20:09 ` Gustavo Padovan
2016-01-21 20:34 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo Padovan @ 2016-01-21 20:09 UTC (permalink / raw)
To: Greg KH; +Cc: Gustavo Padovan, Steven Rostedt, Ingo Molnar, open list
2016-01-21 Greg KH <gregkh@linuxfoundation.org>:
> On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > timeline was wrongly assigned with ->get_driver_name().
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > ---
> > include/trace/events/fence.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h
> > index 98feb1b..d6dfa05 100644
> > --- a/include/trace/events/fence.h
> > +++ b/include/trace/events/fence.h
> > @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on,
> >
> > TP_STRUCT__entry(
> > __string(driver, fence->ops->get_driver_name(fence))
> > - __string(timeline, fence->ops->get_driver_name(fence))
> > + __string(timeline, fence->ops->get_timeline_name(fence))
> > __field(unsigned int, context)
> > __field(unsigned int, seqno)
>
> Why would you send this to: me? I am not the trace maintainer...
Because you are the original committer of the file. But this should have
been addressed to the trace maintainer.
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on
2016-01-21 20:09 ` Gustavo Padovan
@ 2016-01-21 20:34 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-01-21 20:34 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: Gustavo Padovan, Steven Rostedt, Ingo Molnar, open list
On Thu, Jan 21, 2016 at 06:09:05PM -0200, Gustavo Padovan wrote:
> 2016-01-21 Greg KH <gregkh@linuxfoundation.org>:
>
> > On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote:
> > > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > >
> > > timeline was wrongly assigned with ->get_driver_name().
> > >
> > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > > ---
> > > include/trace/events/fence.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h
> > > index 98feb1b..d6dfa05 100644
> > > --- a/include/trace/events/fence.h
> > > +++ b/include/trace/events/fence.h
> > > @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on,
> > >
> > > TP_STRUCT__entry(
> > > __string(driver, fence->ops->get_driver_name(fence))
> > > - __string(timeline, fence->ops->get_driver_name(fence))
> > > + __string(timeline, fence->ops->get_timeline_name(fence))
> > > __field(unsigned int, context)
> > > __field(unsigned int, seqno)
> >
> > Why would you send this to: me? I am not the trace maintainer...
>
> Because you are the original committer of the file.
I did? I have committed lots of files/patches that I am not the
owner/maintainer of.
> But this should have been addressed to the trace maintainer.
scripts/get_maintainer.pl is your friend, please use it :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-21 20:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-21 11:48 [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on Gustavo Padovan
2016-01-21 19:58 ` Greg KH
2016-01-21 20:09 ` Gustavo Padovan
2016-01-21 20:34 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox