Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on

Gustavo Padovan
2016-01-21T20:09:14Z

2016-01-21 Greg KH <gregkh@linuxfoundation.org>:

> On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > timeline was wrongly assigned with ->get_driver_name().
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > ---
> > include/trace/events/fence.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h
> > index 98feb1b..d6dfa05 100644
> > --- a/include/trace/events/fence.h
> > +++ b/include/trace/events/fence.h
> > @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on,
> >
> > TP_STRUCT__entry(
> > __string(driver, fence->ops->get_driver_name(fence))
> > - __string(timeline, fence->ops->get_driver_name(fence))
> > + __string(timeline, fence->ops->get_timeline_name(fence))
> > __field(unsigned int, context)
> > __field(unsigned int, seqno)
>
> Why would you send this to: me? I am not the trace maintainer...

Because you are the original committer of the file. But this should have
been addressed to the trace maintainer.

Gustavo