From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbcAUUo0 (ORCPT ); Thu, 21 Jan 2016 15:44:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51912 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbcAUUoG (ORCPT ); Thu, 21 Jan 2016 15:44:06 -0500 Date: Thu, 21 Jan 2016 15:44:05 -0500 From: Vivek Goyal To: Shaohua Li Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk, tj@kernel.org, jmoyer@redhat.com, Kernel-team@fb.com, linux-block@vger.kernel.org Subject: Re: [RFC 3/3] blk-throttling: detect inactive cgroup Message-ID: <20160121204405.GE8379@redhat.com> References: <6311e9d0e215083504a082b200ef4da020ca7c68.1453308862.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6311e9d0e215083504a082b200ef4da020ca7c68.1453308862.git.shli@fb.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 09:49:19AM -0800, Shaohua Li wrote: > If a cgroup is inactive for some time, it should be excluded from > bandwidth calculation. I am not sure why do we require this patch. If group is inactive, it will not be on service tree and will not contribute to weight hence will not contrinute to share. Thanks Vivek