From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbcAUVVj (ORCPT ); Thu, 21 Jan 2016 16:21:39 -0500 Received: from mail.skyhub.de ([78.46.96.112]:49610 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbcAUVVh (ORCPT ); Thu, 21 Jan 2016 16:21:37 -0500 Date: Thu, 21 Jan 2016 22:21:09 +0100 From: Borislav Petkov To: "H. Peter Anvin" Cc: Huaitong Han , tglx@linutronix.de, mingo@redhat.com, david.vrabel@citrix.com, rusty@rustcorp.com.au, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] x86: use enum cpuid_leafs instead of magic numbers Message-ID: <20160121212109.GK21930@pd.tnic> References: <1453374160-4648-1-git-send-email-huaitong.han@intel.com> <20160121114250.GD21930@pd.tnic> <56A147F9.1000306@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56A147F9.1000306@zytor.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2016 at 01:04:57PM -0800, H. Peter Anvin wrote: > I'm wondering, though, if it wouldn't be better to turn these into > macros so that they can be used in assembly code. That way the > definitions can be interspersed with the X86_FEATURE_ definitions, > too. What concrete use case do you have in mind, i.e., example? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.