Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations

Oreste Salerno
2016-01-21T20:22:11Z

On Thu, Jan 21, 2016 at 11:29:24AM -0800, Dmitry Torokhov wrote:
> Hi Oreste,
>
> On Thu, Jan 21, 2016 at 08:21:13PM +0100, Oreste Salerno wrote:
> > Use devm_() functions for allocating memory, input device and IRQ.
> >
>
> ...
>
> > @@ -625,11 +620,8 @@ EXPORT_SYMBOL_GPL(cyttsp_probe);
> >
> > void cyttsp_remove(struct cyttsp *ts)
> > {
> > - free_irq(ts->irq, ts);
> > - input_unregister_device(ts->input);
> > if (ts->pdata->exit)
> > ts->pdata->exit();
> > - kfree(ts);
>
> This is not quite correct as it changes the operations order... Given
> that it is going to be removed in the next patch I guess it is OK, but
> ideally you can add a custom devm action to shut off the chip.
>

You mean a devm action to call pdata->exit() ? OK, I could do that.

> Thanks.
>
> --
> Dmitry