From: Keith Busch <keith.busch@intel.com>
To: Jens Axboe <axboe@fb.com>
Cc: Stefan Haberland <sth@linux.vnet.ibm.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org,
Sebastian Ott <sebott@linux.vnet.ibm.com>
Subject: Re: [BUG] Regression introduced with "block: split bios to max possible length"
Date: Thu, 21 Jan 2016 22:51:27 +0000 [thread overview]
Message-ID: <20160121225127.GA30993@localhost.localdomain> (raw)
In-Reply-To: <56A14EE4.1020008@fb.com>
On Thu, Jan 21, 2016 at 02:34:28PM -0700, Jens Axboe wrote:
> On 01/21/2016 07:57 AM, Stefan Haberland wrote:
> >Hi,
> >
> >unfortunately commit e36f62042880 "block: split bios to maxpossible length"
> >breaks the DASD driver on s390. We expect the block requests to be
> >multiple
> >of 4k in size. With the patch applied I see the requests split up in
> >multiple
> >of 512 byte and therefore the requests get rejected and lots of I/Os fail.
>
> Sigh, that's definitely a bug. I'll take a look at it and see if I
> can get a tested fix in for 4.5-rc1. If not, we'll revert it, again.
My apologies for the trouble. I trust it really is broken, but I don't
quite see how. The patch supposedly splits the transfer to the max size
the request queue says it allows. How does the max allowed size end up
an invalid multiple?
next prev parent reply other threads:[~2016-01-21 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 14:57 [BUG] Regression introduced with "block: split bios to max possible length" Stefan Haberland
2016-01-21 21:34 ` Jens Axboe
2016-01-21 22:51 ` Keith Busch [this message]
2016-01-22 1:12 ` Linus Torvalds
2016-01-22 3:21 ` Keith Busch
2016-01-22 4:15 ` Linus Torvalds
2016-01-22 14:56 ` Keith Busch
2016-01-22 17:15 ` Jens Axboe
2016-01-22 15:06 ` Ming Lei
2016-01-22 17:03 ` Linus Torvalds
2016-01-22 17:48 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121225127.GA30993@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sebott@linux.vnet.ibm.com \
--cc=sth@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox