linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shaohua Li <shli@kernel.org>
To: Gayatri Kammela <gayatri.kammela@intel.com>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	NeilBrown <neilb@suse.com>, Anton Blanchard <anton@samba.org>,
	Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH] raid6/algos.c : bug fix : Add the missing definitions to the pq.h file
Date: Thu, 21 Jan 2016 15:05:35 -0800	[thread overview]
Message-ID: <20160121230535.GA31453@kernel.org> (raw)
In-Reply-To: <1453413759-16064-1-git-send-email-gayatri.kammela@intel.com>

On Thu, Jan 21, 2016 at 02:02:39PM -0800, Gayatri Kammela wrote:
> Adding these pr_info and pr_err definitions so as to allow code to be
> compiled successfully for testing in userspace, since the printk has
> been replaced by pr_info and pr_err in algos.c
> 
> Absence of these definitions result in the compilation errors
> such as ' undefined reference to `pr_info' ' ' undefined reference to
> `pr_err' '
> 
> Cc: NeilBrown <neilb@suse.com>
> Cc: Anton Blanchard <anton@samba.org>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
> ---
>  include/linux/raid/pq.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/raid/pq.h b/include/linux/raid/pq.h
> index a7a06d1dcf9c..a0118d5929a9 100644
> --- a/include/linux/raid/pq.h
> +++ b/include/linux/raid/pq.h
> @@ -152,6 +152,8 @@ void raid6_dual_recov(int disks, size_t bytes, int faila, int failb,
>  
>  # define jiffies	raid6_jiffies()
>  # define printk 	printf
> +# define pr_err(format, ...) fprintf(stderr, format, ## __VA_ARGS__)
> +# define pr_info(format, ...) fprintf(stdout, format, ## __VA_ARGS__)
>  # define GFP_KERNEL	0
>  # define __get_free_pages(x, y)	((unsigned long)mmap(NULL, PAGE_SIZE << (y), \
>  						     PROT_READ|PROT_WRITE,   \

Applied, thanks!

      reply	other threads:[~2016-01-21 23:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21 22:02 [PATCH] raid6/algos.c : bug fix : Add the missing definitions to the pq.h file Gayatri Kammela
2016-01-21 23:05 ` Shaohua Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160121230535.GA31453@kernel.org \
    --to=shli@kernel.org \
    --cc=anton@samba.org \
    --cc=fenghua.yu@intel.com \
    --cc=gayatri.kammela@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).