From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbcAUXFn (ORCPT ); Thu, 21 Jan 2016 18:05:43 -0500 Received: from mail.kernel.org ([198.145.29.136]:46757 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbcAUXFi (ORCPT ); Thu, 21 Jan 2016 18:05:38 -0500 Date: Thu, 21 Jan 2016 15:05:35 -0800 From: Shaohua Li To: Gayatri Kammela Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, NeilBrown , Anton Blanchard , Fenghua Yu Subject: Re: [PATCH] raid6/algos.c : bug fix : Add the missing definitions to the pq.h file Message-ID: <20160121230535.GA31453@kernel.org> References: <1453413759-16064-1-git-send-email-gayatri.kammela@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453413759-16064-1-git-send-email-gayatri.kammela@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2016 at 02:02:39PM -0800, Gayatri Kammela wrote: > Adding these pr_info and pr_err definitions so as to allow code to be > compiled successfully for testing in userspace, since the printk has > been replaced by pr_info and pr_err in algos.c > > Absence of these definitions result in the compilation errors > such as ' undefined reference to `pr_info' ' ' undefined reference to > `pr_err' ' > > Cc: NeilBrown > Cc: Anton Blanchard > Cc: Fenghua Yu > Signed-off-by: Gayatri Kammela > --- > include/linux/raid/pq.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/raid/pq.h b/include/linux/raid/pq.h > index a7a06d1dcf9c..a0118d5929a9 100644 > --- a/include/linux/raid/pq.h > +++ b/include/linux/raid/pq.h > @@ -152,6 +152,8 @@ void raid6_dual_recov(int disks, size_t bytes, int faila, int failb, > > # define jiffies raid6_jiffies() > # define printk printf > +# define pr_err(format, ...) fprintf(stderr, format, ## __VA_ARGS__) > +# define pr_info(format, ...) fprintf(stdout, format, ## __VA_ARGS__) > # define GFP_KERNEL 0 > # define __get_free_pages(x, y) ((unsigned long)mmap(NULL, PAGE_SIZE << (y), \ > PROT_READ|PROT_WRITE, \ Applied, thanks!