From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753122AbcAVJmM (ORCPT ); Fri, 22 Jan 2016 04:42:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49561 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbcAVJl4 (ORCPT ); Fri, 22 Jan 2016 04:41:56 -0500 Date: Fri, 22 Jan 2016 10:41:53 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout Message-ID: <20160122094153.GC27246@krava.brq.redhat.com> References: <1453256812-24006-1-git-send-email-andi@firstfloor.org> <1453256812-24006-4-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453256812-24006-4-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 06:26:46PM -0800, Andi Kleen wrote: SNIP > uval = avg * counter->scale; > - printout(-1, 0, counter, uval, prefix); > - > - print_noise(counter, avg); > - > - print_running(avg_running, avg_enabled); > + printout(-1, 0, counter, uval, prefix, avg_running, avg_enabled, avg); > fprintf(output, "\n"); > } > > @@ -1037,36 +1006,8 @@ static void print_counter(struct perf_evsel *counter, char *prefix) > if (prefix) > fprintf(output, "%s", prefix); > > - if (run == 0 || ena == 0) { > - fprintf(output, "CPU%*d%s%*s%s", > - csv_output ? 0 : -4, > - perf_evsel__cpus(counter)->map[cpu], csv_sep, > - csv_output ? 0 : 18, > - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED, > - csv_sep); this hunk is not preserved in the new code.. I guess the output is different for -A if counter wasn't meassure? thanks, jirka