From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753207AbcAVKyc (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 Jan 2016 05:54:32 -0500
Received: from mail-pa0-f45.google.com ([209.85.220.45]:35442 "EHLO
	mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753115AbcAVKyI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 Jan 2016 05:54:08 -0500
Date: Fri, 22 Jan 2016 16:23:50 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Peter Hung <hpeter@gmail.com>
Cc: Rob Groner <rgroner@rtd.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        gregkh@linuxfoundation.org, jslaby@suse.com,
        heikki.krogerus@linux.intel.com, peter@hurleysoftware.com,
        soeren.grunewald@desy.de, udknight@gmail.com, adam.lee@canonical.com,
        arnd@arndb.de, yamada.masahiro@socionext.com, mans@mansr.com,
        scottwood@freescale.com, paul.burton@imgtec.com,
        matthias.bgg@gmail.com, manabian@gmail.com, peter.ujfalusi@ti.com,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        peter_hong@fintek.com.tw, Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file
Message-ID: <20160122105350.GA7023@sudip-pc>
References: <1453171266-15874-1-git-send-email-hpeter+linux_kernel@gmail.com>
 <20160119035649.GA1696@windriver.com>
 <569DF7C3.5050306@gmail.com>
 <20160119123327.3b519062@lxorguk.ukuu.org.uk>
 <1453209684.2521.115.camel@linux.intel.com>
 <569EF810.1000304@gmail.com>
 <20160120062214.GB3747@sudip-pc>
 <569F4444.3040104@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <569F4444.3040104@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 20, 2016 at 04:24:36PM +0800, Peter Hung wrote:
> Hi Sudip,
> 
> Sudip Mukherjee 於 2016/1/20 下午 02:22 寫道:
> >On Wed, Jan 20, 2016 at 10:59:28AM +0800, Peter Hung wrote:
> 
> >But my personal opinion, if we move out the serial port related code
> >into a new driver (a new Kconfig symbol) userspace of many system will
> >break if this new symbol is not enabled by the distributions. But in the
> >way I have done the new symbol needs to be enabled only if the user
> >wants to use the GPIO capability. If that is not enabled GPIO cannot be
> >used but it will never break the serial port related code for them.
> >I think we should give a thought to that before splitting out the codes
> >from 8250_pci.
> 
> I agree with your opinion. I'm trying to implement GPIO with 2 ways,
> One is like yours, add platform_device with in 8250_pci.c and implement
> GPIOLIB platform driver with in 'driver/gpio", and the other is trying
> split out from 8250_pci.c to MFD.
> 
> In my personal opinion, the first method is less impact with compatible
> old system.

Looks like no one else is in support of our opinion. Fair enough, I will
split out the related code from 8250_pci and create the MFD driver this
weekend for my hardware.

regards
sudip