From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbcAVLsf (ORCPT ); Fri, 22 Jan 2016 06:48:35 -0500 Received: from down.free-electrons.com ([37.187.137.238]:48823 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752812AbcAVLs3 (ORCPT ); Fri, 22 Jan 2016 06:48:29 -0500 Date: Fri, 22 Jan 2016 12:48:27 +0100 From: Alexandre Belloni To: Nicolas Ferre Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jean-Christophe PLAGNIOL-VILLARD , Ludovic Desroches , Wenyou Yang , Songjun Wu Subject: Re: [PATCH] ARM: at91/dt: sama5d2 Xplained: add phy address and IRQ for macb0 Message-ID: <20160122114827.GF3608@piout.net> References: <1453462174-27688-1-git-send-email-nicolas.ferre@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453462174-27688-1-git-send-email-nicolas.ferre@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/01/2016 at 12:29:34 +0100, Nicolas Ferre wrote : > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091) > the macb0 interface have difficulties to come back from power saving mode if has > address not explicitely set up. explicitly > As the micrel phy on the board is actually configured to show up at address 1 > we use this explicitly. > Adding the phy node and its real address fixes the issue. Maybe you should add that this also add the proper pinmuxing for the IRQ. > > Signed-off-by: Nicolas Ferre > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > index 77ddff036409..e683856c507c 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > @@ -114,9 +114,15 @@ > > macb0: ethernet@f8008000 { > pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_macb0_default>; > + pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>; > phy-mode = "rmii"; > status = "okay"; > + > + ethernet-phy@1 { > + reg = <0x1>; > + interrupt-parent = <&pioA>; > + interrupts = <73 IRQ_TYPE_LEVEL_LOW>; > + }; > }; > > pdmic@f8018000 { > @@ -300,6 +306,10 @@ > bias-disable; > }; > > + pinctrl_macb0_phy_irq: macb0_phy_irq { > + pinmux = ; > + }; > + > pinctrl_pdmic_default: pdmic_default { > pinmux = , > ; > -- > 2.1.3 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com