From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754283AbcAVOcB (ORCPT ); Fri, 22 Jan 2016 09:32:01 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:38596 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753623AbcAVOb6 (ORCPT ); Fri, 22 Jan 2016 09:31:58 -0500 Date: Fri, 22 Jan 2016 06:31:51 -0800 From: Guenter Roeck To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , Sudip Mukherjee , rjw@rjwysocki.net Subject: Re: [PATCH] drm/vc4: Remove broken attempt at GPU reset using genpd. Message-ID: <20160122143151.GA15505@roeck-us.net> References: <1450750124-17020-1-git-send-email-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450750124-17020-1-git-send-email-eric@anholt.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 21, 2015 at 06:08:44PM -0800, Eric Anholt wrote: > I've tested and confirmed that it doesn't actually work. We'll need > to sort out how to do this properly later, but for now just remove it > since it also caused build breakage due to using CONFIG_PM_SLEEP > functions without our Kconfig depending on PM_SLEEP. > > Signed-off-by: Eric Anholt Still broken upstream. FWIW: Acked-by: Guenter Roeck Tested-by: Guenter Roeck > --- > drivers/gpu/drm/vc4/vc4_v3d.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c > index 424d515..314ff71 100644 > --- a/drivers/gpu/drm/vc4/vc4_v3d.c > +++ b/drivers/gpu/drm/vc4/vc4_v3d.c > @@ -144,19 +144,16 @@ int vc4_v3d_debugfs_ident(struct seq_file *m, void *unused) > } > #endif /* CONFIG_DEBUG_FS */ > > -/* > - * Asks the firmware to turn on power to the V3D engine. > - * > - * This may be doable with just the clocks interface, though this > - * packet does some other register setup from the firmware, too. > - */ > int > vc4_v3d_set_power(struct vc4_dev *vc4, bool on) > { > - if (on) > - return pm_generic_poweroff(&vc4->v3d->pdev->dev); > - else > - return pm_generic_resume(&vc4->v3d->pdev->dev); > + /* XXX: This interface is needed for GPU reset, and the way to > + * do it is to turn our power domain off and back on. We > + * can't just reset from within the driver, because the reset > + * bits are in the power domain's register area, and get set > + * during the poweron process. > + */ > + return 0; > } > > static void vc4_v3d_init_hw(struct drm_device *dev) > -- > 2.6.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > >