From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbcAVOhZ (ORCPT ); Fri, 22 Jan 2016 09:37:25 -0500 Received: from mail.kernel.org ([198.145.29.136]:32768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753594AbcAVOhX (ORCPT ); Fri, 22 Jan 2016 09:37:23 -0500 Date: Fri, 22 Jan 2016 11:37:18 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen , Wang Nan Subject: Dynamicly add/remove sort keys was: Re: [PATCH 08/17] perf hists browser: Fix context menu item Message-ID: <20160122143718.GG4034@kernel.org> References: <1452960197-5323-1-git-send-email-namhyung@kernel.org> <1452960197-5323-9-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452960197-5323-9-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Namhyung, While continuing to process this series, I thought about one new feature: A popup menu that would allow adding/removing sort keys, which would entail resorting with the new sort order, what do you think? It may be relatively simple to implement, or I may be missing something, this is just a brainstorm... To avoid reprocessing everything, which may not even be possible (perf top case) we could mark the field as such and when showing such hist_entries it would have a marker. Say DSO wasn't in the sort order, then each bucket wouldn't be for just one DSO, sure, in this case, when invoking the popup to add DSO to the sort order, we would keep those old hist entries around but when showing them the column for DSO would have , in the top case those would at some point decay, with the new ones with this info appearing as time goes by. This is part of a general trend of removing the need to restart the session when wanting to change the sort order, min percent, max stack, etc, etc. Anyway, back to processing patches :-) - Arnaldo