From: Matt Fleming <matt@codeblueprint.co.uk>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-efi@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Robert Elliott <elliott@hpe.com>
Subject: Re: [PATCH v2 3/4] x86/efi: print size and base in binary units in efi_print_memmap
Date: Fri, 22 Jan 2016 15:11:00 +0000 [thread overview]
Message-ID: <20160122151100.GA3747@codeblueprint.co.uk> (raw)
In-Reply-To: <CAHp75VcCvpbamGurVVzXBGcYMCexpTZ4esg8YbKmzAu+iibyrw@mail.gmail.com>
On Fri, 22 Jan, at 09:08:00AM, Andy Shevchenko wrote:
> On Fri, Jan 22, 2016 at 12:35 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 21 Jan 2016 17:22:31 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> >> From: Robert Elliott <elliott@hpe.com>
> >>
> >> Print the base in the best-fit B, KiB, MiB, etc. units rather than
> >> always MiB. This avoids rounding, which can be misleading.
> >>
> >> Use proper IEC binary units (KiB, MiB, etc.) rather than misuse SI
> >> decimal units (KB, MB, etc.).
> >>
> >> old:
> >> efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff) (16384MB)
> >>
> >> new:
> >> efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff] (16 GiB)
> >
> > hm,
> >
> >> @@ -225,21 +235,20 @@ int __init efi_memblock_x86_reserve_range(void)
> >> void __init efi_print_memmap(void)
> >> {
> >> #ifdef EFI_DEBUG
> >> - efi_memory_desc_t *md;
> >> void *p;
> >> int i;
> >>
> >> for (p = memmap.map, i = 0;
> >> p < memmap.map_end;
> >> p += memmap.desc_size, i++) {
> >> - char buf[64];
> >> + efi_memory_desc_t *md = p;
> >> + u64 size = md->num_pages << EFI_PAGE_SHIFT;
> >> + char buf[64], buf3[32];
> >>
> >> - md = p;
> >> - pr_info("mem%02u: %s range=[0x%016llx-0x%016llx] (%lluMB)\n",
> >> + pr_info("mem%02u: %s range=[0x%016llx-0x%016llx] (%s)\n",
> >> i, efi_md_typeattr_format(buf, sizeof(buf), md),
> >> - md->phys_addr,
> >> - md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1,
> >
> > Where did this " - 1" come from? I can't find a tree which has this.
>
> http://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/commit/?h=next&id=b324ee15566d9de933e7926c37a4d091904a513b
>
> >
> >> - (md->num_pages >> (20 - EFI_PAGE_SHIFT)));
> >> + md->phys_addr, md->phys_addr + size - 1,
> >
> > So I did s/ - 1// here, but worried.
>
> I'm pretty sure the series should go via efi tree.
Right, because of the prerequisite patches sat in my tree it makes
sense for them to all be grouped together.
Andrew, would you mind dropping these from your tree and I'll take
everything through the EFI tree?
Additionally, if you and Rasmus wanted to throw a couple of Acked-by
or Reviewed-by tags my way, I'd feel better about the string_helpers
patches.
next prev parent reply other threads:[~2016-01-22 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 15:22 [PATCH v2 1/4] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko
2016-01-21 15:22 ` [PATCH v2 2/4] lib/string_helpers: fix indentation in few places Andy Shevchenko
2016-01-21 15:22 ` [PATCH v2 3/4] x86/efi: print size and base in binary units in efi_print_memmap Andy Shevchenko
2016-01-21 22:35 ` Andrew Morton
2016-01-22 7:08 ` Andy Shevchenko
2016-01-22 15:11 ` Matt Fleming [this message]
2016-01-22 20:10 ` Andrew Morton
2016-01-21 15:22 ` [PATCH v2 4/4] x86/efi: Use proper units in efi_find_mirror() Andy Shevchenko
2016-01-23 5:13 ` [PATCH v2 1/4] lib/string_helpers: export string_units_{2,10} for others James Bottomley
2016-01-23 11:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160122151100.GA3747@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).