From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756748AbcAVXoG (ORCPT ); Fri, 22 Jan 2016 18:44:06 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60400 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756209AbcAVXn7 (ORCPT ); Fri, 22 Jan 2016 18:43:59 -0500 Date: Fri, 22 Jan 2016 15:43:58 -0800 From: Andrew Morton To: Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, keescook@chromium.org, mingo@kernel.org, hpa@zytor.com, heiko.carstens@de.ibm.com, benh@kernel.crashing.org, mpe@ellerman.id.au, mmarek@suse.cz, rusty@rustcorp.com.au, arnd@arndb.de, linux-arch@vger.kernel.org Subject: Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table Message-Id: <20160122154358.e6491d6a963747b449731eb9@linux-foundation.org> In-Reply-To: <20160122153428.8422f42877c7707dbcba0259@linux-foundation.org> References: <1453373299-28181-1-git-send-email-ard.biesheuvel@linaro.org> <1453396783-21591-1-git-send-email-ard.biesheuvel@linaro.org> <20160122153428.8422f42877c7707dbcba0259@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Jan 2016 15:34:28 -0800 Andrew Morton wrote: > > Support for the above is enabled by default for all architectures except > > IA-64, whose symbols are too far apart to capture in this manner. > > scripts/kallsyms.c: In function 'record_relative_base': > scripts/kallsyms.c:744: error: 'ULLONG_MAX' undeclared (first use in this function) > scripts/kallsyms.c:744: error: (Each undeclared identifier is reported only once > scripts/kallsyms.c:744: error: for each function it appears in.) > > That's with (ancient) glibc-headers-2.5-3. It appears that limits.h's > ULLONG_MAX requires "#ifdef __USE_ISOC99". I'm not sure what's the > correct way of turning this on. Actually, how about we replace it with -1ULL and get on with life.