From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754740AbcAVRvg (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 Jan 2016 12:51:36 -0500
Received: from mail.skyhub.de ([78.46.96.112]:47145 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754497AbcAVRvd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 Jan 2016 12:51:33 -0500
Date: Fri, 22 Jan 2016 18:51:03 +0100
From: Borislav Petkov <bp@alien8.de>
To: Huang Rui <ray.huang@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Thomas Gleixner <tglx@linutronix.de>, Robert Richter <rric@kernel.org>,
        Jacob Shin <jacob.w.shin@gmail.com>,
        John Stultz <john.stultz@linaro.org>,
        =?utf-8?B?RnLvv71k77+9cmlj?= Weisbecker <fweisbec@gmail.com>,
        linux-kernel@vger.kernel.org, spg_linux_kernel@amd.com, x86@kernel.org,
        Guenter Roeck <linux@roeck-us.net>,
        Andreas Herrmann <herrmann.der.user@googlemail.com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
        Fengguang Wu <fengguang.wu@intel.com>, Aaron Lu <aaron.lu@intel.com>
Subject: Re: [PATCH v2 5/5] perf/x86/amd/power: Add AMD accumulated power
 reporting mechanism
Message-ID: <20160122175103.GG9806@pd.tnic>
References: <1452739808-11871-6-git-send-email-ray.huang@amd.com>
 <20160119121250.GA6344@twins.programming.kicks-ass.net>
 <20160120044823.GA13477@hr-amur2>
 <20160120092244.GH6357@twins.programming.kicks-ass.net>
 <20160121070437.GA15130@hr-amur2>
 <20160121090257.GC6357@twins.programming.kicks-ass.net>
 <20160121144233.GA16294@hr-amur2>
 <20160121151040.GO6356@twins.programming.kicks-ass.net>
 <20160121165958.GF21930@pd.tnic>
 <20160122080439.GB16975@hr-amur2>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160122080439.GB16975@hr-amur2>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 22, 2016 at 04:04:40PM +0800, Huang Rui wrote:
> OK, you're right. Peter, Boris, thanks for your information.
> I might need look at topology deeper. :-)
> 
> So how about below update:

Please send a full patch, not those diffs ontop - I don't know about
Peter but I absolutely can't grok it this way.

> BTW, "smp_num_siblings = ((ebx >> 8) & 3) + 1" should not put under
> init_amd(), we would better move it to bsp_init_amd(). Because the AMD
> "smp_num_siblings" number must be constant.

You can send me a fix once your other stuff hits tip and you can base it
ontop.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.