From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754847AbcAVSoY (ORCPT ); Fri, 22 Jan 2016 13:44:24 -0500 Received: from kanga.kvack.org ([205.233.56.17]:47437 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754402AbcAVSoV (ORCPT ); Fri, 22 Jan 2016 13:44:21 -0500 Date: Fri, 22 Jan 2016 13:44:20 -0500 From: Benjamin LaHaise To: Guenter Roeck Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org Subject: Re: [PATCH -next] aio: Fix compile error due to unexpected use of cmpxchg() Message-ID: <20160122184420.GR12249@kvack.org> References: <1453486479-19347-1-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453486479-19347-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2016 at 10:14:39AM -0800, Guenter Roeck wrote: > cmpxchg() on some architectures (ia64) doesn't like functions as parameters. > This results in the following compile error on the affected architectures. > > fs/aio.c: In function 'aio_thread_fn': > fs/aio.c:1499:1: error: cast specifies function type > Fixes: 6a81013efc40 ("aio: add support for IOCB_CMD_POLL via aio thread helper") Ah, I was wondering if there was an easy way to fix this bug. Applied -- thanks! -ben > Cc: Benjamin LaHaise > Signed-off-by: Guenter Roeck > --- > No idea if this is the correct or an acceptable fix. > If not, please consider this to be a bug report. > > fs/aio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > index 56bcdf4105f4..229a91e391df 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -1495,8 +1495,8 @@ static void aio_thread_fn(struct work_struct *work) > * cancellation if it has not already occurred. > */ > old_cancel = cmpxchg(&iocb->ki_cancel, > - aio_thread_queue_iocb_cancel_early, > - aio_thread_queue_iocb_cancel); > + (kiocb_cancel_fn *)aio_thread_queue_iocb_cancel_early, > + (kiocb_cancel_fn *)aio_thread_queue_iocb_cancel); > if (old_cancel != KIOCB_CANCELLED) > ret = iocb->ki_work_fn(iocb); > else > -- > 2.1.4 -- "Thought is the essence of where you are now."