From: Keith Busch <keith.busch@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ming Lei <tom.leiming@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-block@vger.kernel.org,
Stefan Haberland <sth@linux.vnet.ibm.com>
Subject: Re: [PATCH] block: fix bio splitting on max sectors
Date: Fri, 22 Jan 2016 20:11:17 +0000 [thread overview]
Message-ID: <20160122201116.GB21984@localhost.localdomain> (raw)
In-Reply-To: <CA+55aFx+gP1+ztJ+THoxLpXkpv83k9JRikG7nD7cY1xByOpCAw@mail.gmail.com>
On Fri, Jan 22, 2016 at 10:43:59AM -0800, Linus Torvalds wrote:
> On Fri, Jan 22, 2016 at 10:29 AM, Ming Lei <tom.leiming@gmail.com> wrote:
> >
> > This patch fixes the issue by making the max io size aligned
> > to logical block size.
>
> Looks better, thanks.
>
> I'd suggest also moving the "max_sectors" variable into the
> bio_for_each_segment() loop too just to keep variables with minimal
> scope, but at least this is fairly legible.
The value of max_sectors doesn't change in this function, so its
calculation could be done just once instead of with each segment
iteration.
Other than that, thanks Ming, the fix looks good to me. Third try's
a charm?
next prev parent reply other threads:[~2016-01-22 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 18:29 [PATCH] block: fix bio splitting on max sectors Ming Lei
2016-01-22 18:43 ` Linus Torvalds
2016-01-22 20:11 ` Keith Busch [this message]
[not found] ` <CA+55aFxkbTy13mPEQmoXY4L9gbakwz5NQCiLaEnjfhFtUXjtYg@mail.gmail.com>
2016-01-22 20:32 ` Linus Torvalds
2016-01-22 20:33 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160122201116.GB21984@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sth@linux.vnet.ibm.com \
--cc=tom.leiming@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).