From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722AbcAVUdy (ORCPT ); Fri, 22 Jan 2016 15:33:54 -0500 Received: from mga02.intel.com ([134.134.136.20]:40373 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752631AbcAVUdw (ORCPT ); Fri, 22 Jan 2016 15:33:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,332,1449561600"; d="scan'208";a="732532052" Date: Fri, 22 Jan 2016 20:33:51 +0000 From: Keith Busch To: Linus Torvalds Cc: Stefan Haberland , Jens Axboe , Linux Kernel Mailing List , linux-block@vger.kernel.org, Ming Lei Subject: Re: [PATCH] block: fix bio splitting on max sectors Message-ID: <20160122203350.GA29201@localhost.localdomain> References: <1453487372-8391-1-git-send-email-tom.leiming@gmail.com> <20160122201116.GB21984@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2016 at 12:22:18PM -0800, Linus Torvalds wrote: > > On Jan 22, 2016 12:11 PM, "Keith Busch" wrote: > > > > The value of max_sectors doesn't change in this function > > Why do you say that? It depends on the offset, so it clearly *does* change. The only "offset" used is the bio's start sector, which doesn't change.