From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755562AbcAWAgl (ORCPT ); Fri, 22 Jan 2016 19:36:41 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36435 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbcAWAgh (ORCPT ); Fri, 22 Jan 2016 19:36:37 -0500 Date: Fri, 22 Jan 2016 16:36:34 -0800 From: Brian Norris To: Boris Brezillon Cc: Christophe JAILLET , dwmw2@infradead.org, kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: nand: mpc5121: use 'of_machine_is_compatible' to simplify code Message-ID: <20160123003634.GA16842@google.com> References: <1452408399-5840-1-git-send-email-christophe.jaillet@wanadoo.fr> <20160111135558.6ebd1165@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160111135558.6ebd1165@bbrezillon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2016 at 01:55:58PM +0100, Boris Brezillon wrote: > On Sun, 10 Jan 2016 07:46:39 +0100 > Christophe JAILLET wrote: > > > The current code is the same as 'of_machine_is_compatible'. > > So use it in order to remove a few lines of code and to be more > > consistent with other parts of the kernel. > > > > Signed-off-by: Christophe JAILLET > > Your patch looks good from a functional POV, but what is this board > detection hack doing in the NAND driver code in the first place? > > Let's say I didn't see that :-). :) > Reviewed-by: Boris Brezillon Applied to l2-mtd.git/next