From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755767AbcAWDnM (ORCPT ); Fri, 22 Jan 2016 22:43:12 -0500 Received: from one.firstfloor.org ([193.170.194.197]:48123 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755250AbcAWDnH (ORCPT ); Fri, 22 Jan 2016 22:43:07 -0500 Date: Sat, 23 Jan 2016 04:43:05 +0100 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout Message-ID: <20160123034304.GD31686@two.firstfloor.org> References: <1453256812-24006-1-git-send-email-andi@firstfloor.org> <1453256812-24006-4-git-send-email-andi@firstfloor.org> <20160122094153.GC27246@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160122094153.GC27246@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > - if (run == 0 || ena == 0) { > > - fprintf(output, "CPU%*d%s%*s%s", > > - csv_output ? 0 : -4, > > - perf_evsel__cpus(counter)->map[cpu], csv_sep, > > - csv_output ? 0 : 18, > > - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED, > > - csv_sep); > > this hunk is not preserved in the new code.. I guess the output is > different for -A if counter wasn't meassure? The code for this is common in printout() now. -Andi