From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751965AbcAWHyZ (ORCPT <rfc822;w@1wt.eu>);
	Sat, 23 Jan 2016 02:54:25 -0500
Received: from mail-lf0-f66.google.com ([209.85.215.66]:36638 "EHLO
	mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751374AbcAWHyV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 23 Jan 2016 02:54:21 -0500
Date: Sat, 23 Jan 2016 10:54:15 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: linux-mm@kvack.org, Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        Vegard Nossum <vegard.nossum@oracle.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Vladimir Davydov <vdavydov@virtuozzo.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Quentin Casasnovas <quentin.casasnovas@oracle.com>,
        Kees Cook <keescook@google.com>, Willy Tarreau <w@1wt.eu>,
        Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: [PATCH 1/2] mm: do not limit VmData with RLIMIT_DATA
Message-ID: <20160123075415.GH2262@uranus>
References: <145353478067.23962.14991739413777907906.stgit@zurg>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <145353478067.23962.14991739413777907906.stgit@zurg>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 23, 2016 at 10:39:40AM +0300, Konstantin Khlebnikov wrote:
> This partially reverts 84638335900f ("mm: rework virtual memory accounting")
> 
> Before that commit RLIMIT_DATA have control only over size of the brk region.
> But that change have caused problems with all existing versions of valgrind
> because they set RLIMIT_DATA to zero for some reason.
> 
> More over, current check has a major flaw: RLIMIT_DATA in bytes,
> not pages. So, some problems might have slipped through testing.
> Let's revert it for now and put back in next release.
> 
> Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
> Link: http://lkml.kernel.org/r/20151228211015.GL2194@uranus
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>

Looks great for me. Thanks a lot, Kostya!
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>