From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752473AbcAWKOw (ORCPT <rfc822;w@1wt.eu>);
	Sat, 23 Jan 2016 05:14:52 -0500
Received: from mail.skyhub.de ([78.46.96.112]:58843 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751707AbcAWKOt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 23 Jan 2016 05:14:49 -0500
Date: Sat, 23 Jan 2016 11:14:15 +0100
From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        Fenghua Yu <fenghua.yu@intel.com>, Oleg Nesterov <oleg@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        yu-cheng yu <yu-cheng.yu@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Rik van Riel <riel@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 4/5] x86/fpu: Speed up lazy FPU restores slightly
Message-ID: <20160123101415.GB16329@pd.tnic>
References: <cover.1453510332.git.luto@kernel.org>
 <93f2a482fce2ac1815d324344d03ff26ceabe439.1453510332.git.luto@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <93f2a482fce2ac1815d324344d03ff26ceabe439.1453510332.git.luto@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 22, 2016 at 04:56:05PM -0800, Andy Lutomirski wrote:
> If we have an FPU, there's no need to check CR0 for FPU emulation.
> 
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>  arch/x86/kernel/traps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> index 87f80febf477..183b300f6a8b 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -752,7 +752,7 @@ do_device_not_available(struct pt_regs *regs, long error_code)
>  	RCU_LOCKDEP_WARN(!rcu_is_watching(), "entry code didn't wake RCU");
>  
>  #ifdef CONFIG_MATH_EMULATION
> -	if (read_cr0() & X86_CR0_EM) {
> +	if (!cpu_has_fpu && (read_cr0() & X86_CR0_EM)) {

Please use

	boot_cpu_has(X86_FEATURE_FPU)

We want to kill those cpu_has_xxx things.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.