From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577AbcAWKZp (ORCPT ); Sat, 23 Jan 2016 05:25:45 -0500 Received: from mail-by2on0081.outbound.protection.outlook.com ([207.46.100.81]:16189 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751735AbcAWKZk (ORCPT ); Sat, 23 Jan 2016 05:25:40 -0500 X-Greylist: delayed 38815 seconds by postgrey-1.27 at vger.kernel.org; Sat, 23 Jan 2016 05:25:40 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@caviumnetworks.com; Date: Sat, 23 Jan 2016 11:25:23 +0100 From: Robert Richter To: Hanjun Guo CC: "Rafael J. Wysocki" , Will Deacon , Catalin Marinas , , , , Ganapatrao Kulkarni , Lorenzo Pieralisi , Shannon Zhao , Steve Capper , Mark Rutland , Hanjun Guo Subject: Re: [PATCH v3 04/12] acpi, numa: introduce ACPI_HAS_NUMA_ARCH_FIXUP Message-ID: <20160123102523.GC24726@rric.localdomain> References: <1453541967-3744-1-git-send-email-guohanjun@huawei.com> <1453541967-3744-5-git-send-email-guohanjun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1453541967-3744-5-git-send-email-guohanjun@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [78.53.83.103] X-ClientProxiedBy: DB4PR01CA0055.eurprd01.prod.exchangelabs.com (10.242.152.45) To BN3PR0701MB1607.namprd07.prod.outlook.com (25.163.38.30) X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1607;2:2Uxp3lvYQr8VE3F+/djU92DBNfLpYmxES9K2v1+/Tf7cBOq/fIaH2UG9RNI17OC0gPyl0uh468u9JOh+EgS1DV7B+wz1qSUkShb2MGxSU+dZfS5Gr/2Lh6Cb4CpU67xWj4XsgVXGO3wGTks6GpgC2Q==;3:2dAGCfNrtiuWRpibZcPyidQdEaJarV+N/GjhJDLLLK3aUtqiQGhlb7FXk8Un4pxrkVdEn23d9eW8VOUUPKYUzxHlZnubGsmTt6i5CkkAAU9kNHcFA/MM44knTht5XulW;25:L+ZcS6ayaCC8/QDGDolnIGIR/VKeTLbbN87REjqP409fVs/aD4hwv+vLsjQi6VBFeJNmiyTPCSscyuwMUDcPiQF0IZp3XLq4A85b5l3LmzPmqDE4l1y9uBL4hqqszp5VpXZZQthpXQR9TN7DAjCgqPMJaUjXVqJAwbAWg4K4RWs0Ej6lK5/kdaCUn+lpKgaXr4wR+GIMYGy2OCL/r1JYzyq2muEjbTQ5oLS/dUJMyBEa9wF+Arpd5nufPvKifcHW X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1607; X-MS-Office365-Filtering-Correlation-Id: b0cf4ccb-619c-4e78-a6d6-08d323df8969 X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1607;20:CCaYxNYHo1gmgB+ThKWCHQlwHXkkIONIteqkbN1m1j0gPgnV0BL6DkgH73wQfC6zehdHH+ptevZeFn3lNi7elnJPpcN8MrhRXHKqJ3tAA9+MBrVKOXrDziEIhTDU6TkE+h9+3XhPlUY/6Td6smN/d8UxPOF8ERCY0B68M3fVbBzp6AIiV4HA87PnzyOTVVKhOzA1b2tDbnh1UKtJdRhQmhYBYIlzYa+/tDR2IQ6jaRsrbpTeGEIkb+AtyIdRafvp8bd8Zdo8XQYyA73vGNAxXbSL8LxIb/8HZJ6kyXSQ9oH0Z+n82yayih2c500WdA+zZbfU3Qt1nV+Nei4WKJOGDFiXv6aVfHtBt+dHx6CKROde8lNwLyZpnOySEdaT+pgvKiM9thiMLi+42pHqI+0FGKWHM/3phVnODhlypY7A8MARZw2+YoNJypfa+5XhW2hqi75dhEqvU2p/vkMEU31MY51FnOK5KsEz/0qB7Ktpz9yozrFdj3o1ApLOvkT6Yox7aJ4WSHIbqCyVtZ+tDx37vnG04aNcjuz7+qXGgznKYoSvbUY0I/qtsgcRJ/rPLN2Ps3ZI2ZkekJiHqxDBOSEs0ZoC1myjrC5qCI8DQd/PjTc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(123027)(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:BN3PR0701MB1607;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1607; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1607;4:WGfUmmLImETNtpSQwwR6xeXDXYr6f4trCKNrS+fixFfR+su2/xGGhwnrhUx5Il+Z90DYNgAXcwuXfnqb+nQM7aeU/6iYOUfMfaprouHbkLM3k9ZxGvap0o9o1oSGNUnCrYEv9IVsFjbHtat3H7RZU0YJck43w5xeZFXqKJ694PaXfTxzcucVCMYanmUMw6E3vW7QleSj2/SsvWMZpr6u0dZUI13NWISKuv0W34aFqna7Rj+B+/dsqc72XDQTB7dfWwe1qTZbnIOG4l2vevSuBWvn6hseP0PRCRwYz2Jl2VV9JKBaCaS6WDALizr+MuvFRXjh2ffvJBQ1DcRXXVq/zIIcZPJaWRaTKkeNzjIk0ws/7puTUMxAj9iEVCROfR0/n2YzPyKu1pW/LlxAk8osBg== X-Forefront-PRVS: 0830866D19 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(199003)(24454002)(189002)(2950100001)(83506001)(86362001)(87976001)(33656002)(77096005)(92566002)(105586002)(4326007)(19580395003)(54356999)(19580405001)(42186005)(101416001)(50986999)(106356001)(122386002)(47776003)(6116002)(97756001)(76176999)(1096002)(81156007)(50466002)(46406003)(1076002)(97736004)(586003)(189998001)(2906002)(5008740100001)(110136002)(5001960100002)(5004730100002)(66066001)(23726003)(4001350100001)(40100003)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1607;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0701MB1607;23:IzFrGJmSXv/KGoT36X76NLFasRBB4YOTLNxFKhs?= =?us-ascii?Q?ldErBhLVzncFvYXh3NI1w4/ebEglnUDfIb4PwCSTNzJZo8sZDdLOj2+pAdoY?= =?us-ascii?Q?VI77EhhXtooNQQLI5MvHorKzzopM/AXXioPuTffGnYZyostR7gdFitBz6Z7v?= =?us-ascii?Q?dGO8hX7j4eRS8Gv7xdUo1bTdIEfj63CSFbjT8xxqtOvsLjvqcJ56E/UdZeSu?= =?us-ascii?Q?aR8gUsiRKtyjm9Mdm7OT1B8sdfyESaHpodIS1ZGEhu2beFjKYMbKfF7Kf2UY?= =?us-ascii?Q?cY92bz8lezsDYHF+3WOHucvePLj1zg+sEbQ9lqxJw09kEWMUM33bp0CfwtzQ?= =?us-ascii?Q?HPWe6pQESY1o34eoOzQpvJvx25DUiZKccEiiFGZH6baWk69Xs6tVCJ/3/9lS?= =?us-ascii?Q?2Ons7tKlpL2G5obuXoT59QEhh4eVrPMd4YSbAXN36oXNDg7vvF6Eb9+AaSYD?= =?us-ascii?Q?vuFq1b5WwWInLbmVgHXYtjHQSIZB/O43sctpThcqoSNqG0D6tkf7U4jzaMxZ?= =?us-ascii?Q?nEH0jnK88N6QctJ7D+Cps0WoT0WfQZXPWIi96FKQ3McA+Ix4qjzsIG9tBWsT?= =?us-ascii?Q?hxW2PjcfuTDaCWLgDRruiyp42SJzJv/U1exEkwFw00RvD2/D8+tHcJDt+trT?= =?us-ascii?Q?W5mXBbAV9LdMs3UiF9+q2mHZmo8uDCDWMfmICMA4VOt5OKBHgq1caNxVwz80?= =?us-ascii?Q?uW5V43QQXDu2WifLvYW5Y1V7CkD0lD5yQNkngTswH1g6jJ6Dt1wYdIPsJpuJ?= =?us-ascii?Q?KZs1Ly5n+8kU9//j+WgWmJKMuBbnXCPK3jEQ9TzORzxdLCiHUuHpvYziOaoT?= =?us-ascii?Q?PMlK1WUCX4j9cJnG6mUPnN1c1F5j2VGje5SZpmk6WaqQzYGpYtkdsNNFhrX1?= =?us-ascii?Q?gyNdhddP8suZ0GAhzuq5mzImsrTO1nO0sqEOff/XnOOvffp3rLrMCxb72kJX?= =?us-ascii?Q?qBFPHaPMVhNyeJYDjf3TQhWB4Q4lqk+HMNprUFVqU2WyIVZm0D/r9ZgFArbj?= =?us-ascii?Q?cQHTAoIKBlQeaykV9Z6n4E40E8uBIuJQmg7aUHWlgwHz/5wHX1V9LslPg0rC?= =?us-ascii?Q?wwb/jjgeQCrXVC9NTkFtKNofefYMjUG5ozZjZw+TZ9AX09zhYsHvfdhDq3b+?= =?us-ascii?Q?zqShLZSknnpk=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1607;5:pLGiyuUzf4vSDzyyKdzO4ytqurLXrNgpmlY4EezCGdx/EDTcWO+pODbxCIGuQWZEjDpU8rs5I5nxM8kERwDBxq9AxlSyY4rhwV+r+GMAImUsyvcqeuEGbJubaUVvlrMa780sOd7VunLrezwleUV08w==;24:NrZDhj+Y62RDl4QEkjWW10fitnkKYrwNQQsYW8wrHfLUwCsgv5zt3mGe++DBBts8+IAuYjtTRruycZPUIiZ05KQPN519lLfFCpXeCqDypOU= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2016 10:25:35.5546 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1607 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.01.16 17:39:19, Hanjun Guo wrote: > From: Hanjun Guo > > acpi_numa_arch_fixup() is only used for IA64, x86 introduce a dummy > function for it, when we came to a new architecture (such as ARM64), > we need to introduce another dummy one to make the code compile. > > That's pretty boring so introduce ACPI_HAS_NUMA_ARCH_FIXUP and > select it for IA64, introduce a stub function for acpi_numa_arch_fixup() > then it's pretty clean for x86 and ARM64. > > Signed-off-by: Hanjun Guo > --- > arch/ia64/Kconfig | 1 + I see an implementation of acpi_numa_arch_fixup() only for ia64. Why not move it to arch/ia64 then and call it from setup_arch() in arch/ia64/kernel/setup.c after acpi_numa_init()? It looks like we don't need a generic solution for this. This avoids any kconfig handling for this at all. -Robert