From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbcAWQUH (ORCPT ); Sat, 23 Jan 2016 11:20:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50961 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbcAWQUD (ORCPT ); Sat, 23 Jan 2016 11:20:03 -0500 Date: Sat, 23 Jan 2016 17:19:58 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout Message-ID: <20160123161958.GA30110@krava.local> References: <1453256812-24006-1-git-send-email-andi@firstfloor.org> <1453256812-24006-4-git-send-email-andi@firstfloor.org> <20160122094153.GC27246@krava.brq.redhat.com> <20160123034304.GD31686@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160123034304.GD31686@two.firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 23, 2016 at 04:43:05AM +0100, Andi Kleen wrote: > > > - if (run == 0 || ena == 0) { > > > - fprintf(output, "CPU%*d%s%*s%s", > > > - csv_output ? 0 : -4, > > > - perf_evsel__cpus(counter)->map[cpu], csv_sep, > > > - csv_output ? 0 : 18, > > > - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED, > > > - csv_sep); > > > > this hunk is not preserved in the new code.. I guess the output is > > different for -A if counter wasn't meassure? > > The code for this is common in printout() now. but what will be printed for -A not counted counters? not the "CPU%*d%s%*s%s" ... jirka