From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbcAWRBb (ORCPT ); Sat, 23 Jan 2016 12:01:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36434 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753547AbcAWRB0 (ORCPT ); Sat, 23 Jan 2016 12:01:26 -0500 Date: Sat, 23 Jan 2016 18:01:21 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist entries Message-ID: <20160123170121.GB4675@krava.local> References: <1453470100-8637-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453470100-8637-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2016 at 10:41:33PM +0900, Namhyung Kim wrote: > Hi, > > This patchset checks error case during the process of collapsing hist > entries. It's a preparation of upcoming hierarchy patchset which adds > more work in the collapsing path. If there's an error during this > stage, it'll stop processing and show warning to user. > > Thanks, > Namhyung > > > Namhyung Kim (7): > perf callchain: Check return value of add_child() > perf callchain: Check return value of fill_node() > perf callchain: Add enum match_result for match_chain() > perf callchain: Check return value of split_add_child() > perf callchain: Check return value of append_chain_children() > perf hists: Return error from hists__collapse_resort() > perf report: Check error during report__collapse_hists() I saw 2 other functions allocating memory and not checked: callchain_cursor_append callchain_node__make_parent_list thanks, jirka