From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754055AbcAXEi5 (ORCPT ); Sat, 23 Jan 2016 23:38:57 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33285 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753519AbcAXEiz (ORCPT ); Sat, 23 Jan 2016 23:38:55 -0500 Date: Sun, 24 Jan 2016 13:37:55 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist entries Message-ID: <20160124043755.GA6846@danjae.kornet> References: <1453470100-8637-1-git-send-email-namhyung@kernel.org> <20160123170121.GB4675@krava.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160123170121.GB4675@krava.local> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 23, 2016 at 06:01:21PM +0100, Jiri Olsa wrote: > On Fri, Jan 22, 2016 at 10:41:33PM +0900, Namhyung Kim wrote: > > Hi, > > > > This patchset checks error case during the process of collapsing hist > > entries. It's a preparation of upcoming hierarchy patchset which adds > > more work in the collapsing path. If there's an error during this > > stage, it'll stop processing and show warning to user. > > > > Thanks, > > Namhyung > > > > > > Namhyung Kim (7): > > perf callchain: Check return value of add_child() > > perf callchain: Check return value of fill_node() > > perf callchain: Add enum match_result for match_chain() > > perf callchain: Check return value of split_add_child() > > perf callchain: Check return value of append_chain_children() > > perf hists: Return error from hists__collapse_resort() > > perf report: Check error during report__collapse_hists() > > I saw 2 other functions allocating memory and not checked: > callchain_cursor_append Ok, but this function is basically for the 'addition' path. Well it's also used by the 'collapsing' path but it never allocates new node since it reuses the existing ones. I'll prepare a different patchset for the 'addition' path later.. > callchain_node__make_parent_list It seems not called in the collapsing path. It should be handled by a separate patchset. Thanks, Namhyung