From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374AbcAYF6P (ORCPT ); Mon, 25 Jan 2016 00:58:15 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:34850 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbcAYF6M (ORCPT ); Mon, 25 Jan 2016 00:58:12 -0500 Date: Mon, 25 Jan 2016 11:28:09 +0530 From: Viresh Kumar To: Shilpasri G Bhat Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, linux-pm@vger.kernel.org, pc@us.ibm.com, anton@samba.org, ego@linux.vnet.ibm.com, shreyas@linux.vnet.ibm.com Subject: Re: [PATCH v6 4/5] cpufreq: powernv: Replace pr_info with trace print for throttle event Message-ID: <20160125055809.GC3183@vireshk> References: <1453447145-17722-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <1453447145-17722-5-git-send-email-shilpa.bhat@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453447145-17722-5-git-send-email-shilpa.bhat@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-01-16, 12:49, Shilpasri G Bhat wrote: > Currently we use printk message to notify the throttle event. But this > can flood the console if the cpu is throttled frequently. So replace the > printk with the tracepoint to notify the throttle event. And also events > like throttle below nominal frequency and OCC_RESET are reduced to > pr_warn/pr_warn_once as pointed by MFG to not mark them as critical > messages. This patch adds 'throt_reason' to struct chip to store the > throttle reason. > > Signed-off-by: Shilpasri G Bhat > Reviewed-by: Gautham R. Shenoy > --- > No changes from v5. You have done too many things in a single patch, its always better to keep a patch for a special problem. Don't try to solve everything in the same patch. Though, I am NOT strongly saying that you respin this patch now. Acked-by: Viresh Kumar -- viresh