From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbcAYK1H (ORCPT ); Mon, 25 Jan 2016 05:27:07 -0500 Received: from mail-bl2on0099.outbound.protection.outlook.com ([65.55.169.99]:44352 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755453AbcAYK1D (ORCPT ); Mon, 25 Jan 2016 05:27:03 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@caviumnetworks.com; Date: Mon, 25 Jan 2016 11:26:43 +0100 From: Robert Richter To: Hanjun Guo CC: "Rafael J. Wysocki" , Will Deacon , Catalin Marinas , , , , Ganapatrao Kulkarni , Lorenzo Pieralisi , Shannon Zhao , Steve Capper , Mark Rutland , Hanjun Guo Subject: Re: [PATCH v3 12/12] acpi, numa: reuse acpi_numa_memory_affinity_init() Message-ID: <20160125102643.GF24726@rric.localdomain> References: <1453541967-3744-1-git-send-email-guohanjun@huawei.com> <1453541967-3744-13-git-send-email-guohanjun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1453541967-3744-13-git-send-email-guohanjun@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.194.101] X-ClientProxiedBy: VI1PR02CA0007.eurprd02.prod.outlook.com (25.162.7.145) To CY1PR0701MB1614.namprd07.prod.outlook.com (25.163.20.151) X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1614;2:tZub7N/ROjR+Y3I+SBvb11YyBPXZF/NHT11V9VUXIl+z1JfPgHpt7ifqFtE/KujIuaRdKuOmCqFb+WtU1pymZ2mraPv5Yyzlt5l1jZC7VRejMLfjYx/Zuc5R1AeNGWTn/LbPgLTibKsS6MsQVeN3yw==;3:nn0KZO5TOOEdLvYzyJSKWXIjoQBeMpW5u7bz+UxpIHGqXC9ekWmnug6eUTe2OaDiwWR8qGBdzOUUjs5cWEhASqNtQyS5a1RPZwZjxJJS71NWSLtOUX8i1DJcUaFFhpRp;25:vLDmqSWsLIkhFVf7SCx1zDP/ekx6xIpzpm4pXKOwavq6p80tkVRFU53dH7oUhMx26HmnUcDBGQPb1rAyGagemBWp7h9V5/2guy+cKEbQ6ZHj7VSZZ+0fW/sl5g1cZTa0INSbprHwU1QT9euNbe+n7GwRqomQ3JsKEZorWLiGmJHLWhZDgbVqWAWZviH4xInAltlS+TFnJj2+6vxMBNt7COIDjE2rA4MPRRifQw/9FROFJFyxqtEUmyOBOJV4rg4e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1614; X-MS-Office365-Filtering-Correlation-Id: ac41c303-e8a8-4fca-7deb-08d325720f22 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1614;20:JqjGKBp/f7lEfMtPKffoEvSQu8mruxL7Wd7hTJG1bylJGmZgx2buQl/RPxmXalLhHY0xbJM46bjYJmVu+xg9i6WoVmOYEhYE6OzrJnnq/yhUEd+pj6vsm5CjISsVgM5T0mdeMXtm574NUKMoza1uEAB55JnukaU88iVyD9130/gFivUq5x56j31PyV/Bo+KL7Xby0S+iI+55AM3WxKsUKN1pIBbNUHlA8e3JmF+RNx7dusay6MTBTFRl05uySQgYKbijlxQWDz02cp5SpGyUP01CizO1q9UUPP/42YFDTAYmiDCaV2DWvQO+K1UuMN5CBZ6HqlulKlBoQOpmgsuW/tbonGRMHzUW2udipmkTkdt+wFVCyONS6tY/GaQsCA4GjNvtyX2lO6TffEQUVLB3eYuAQb0IxudmATKGWnCLLQFlnXXkFnELwqvORN/Agvdy+K/ZuWaSwDfWm5vXvpUYAoqKAai2UkO+iOSI0slJ4se3L9XEfE/IxDG52M3ct8f7TBLKutEzr6KbsZlzu0SVf6BThTtiNnqHNldTuf22LJTFCSSs9zkiolyN5qU+O8YteHmYW5F3mTEWsIvdLIPecE+o13QrTKMiOPC53BriqPA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(123027)(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:CY1PR0701MB1614;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1614; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1614;4:w6wHWqYdvTONlrCrse1kwAgDLetCTnmsxBZzej6nlabD8RmmTA1LCdRL+lMiDw6LFVF2O7YRgCJhEEjAj6MCw0hJuiBe+39wYvYj7UAGfOMHWjI1f5xtTdnfc7SsGgR+17DbkGGSDk8geVEmd5Wk3w1QncNA1inm51wLkrpPwjCRRBPN6zy6x6uwf95uic+8vSZBXnwgKeBXoHlRkRN52/eyYlZqzXsmqKT0xq+9WIMG5I+9kIeTEYWEiEs3Py89HTp6ZX2/oUqy2cBvW8espMd93E87fOk5BrKhTG7lY9F1LzJxCAF1WrjHjF/haLNoEX11OwnfebpnNxJmo4wfEk0P7SQK6TcRcLLUgI2ciV/R7GtK62D3jiPFvwBXTappvBXlLz9eVP6/eVbI00mBhg== X-Forefront-PRVS: 083289FD26 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(189002)(199003)(77096005)(5001960100002)(54356999)(2950100001)(3846002)(23726003)(110136002)(1096002)(50986999)(105586002)(5008740100001)(76176999)(586003)(106356001)(97736004)(33656002)(4001350100001)(81156007)(66066001)(47776003)(101416001)(1076002)(189998001)(6116002)(87976001)(19580395003)(97756001)(19580405001)(2906002)(50466002)(122386002)(42186005)(83506001)(4326007)(46406003)(5004730100002)(40100003)(86362001)(92566002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0701MB1614;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0701MB1614;23:mIz0xRV4Dnwz7RhbxEEUxPlgJKh6P/JYurVInNw?= =?us-ascii?Q?SOgUFX2IZg+9CaIvOZtegS5tJrhEiTRR+qJlmqB8mxoxlMuVe3F2lJIS2NtG?= =?us-ascii?Q?t2rJUNVsnxqQeX5Wfe3BVvGl80jv37IYeHuDEA9K8KSdjxknVDWorBTaLv6p?= =?us-ascii?Q?8F4uxU0BD+UZlZ594cpJy5CSJfl+d7GPoCNTEi3nlpwKBn8mALjgAgRELeDg?= =?us-ascii?Q?kL4qyKN7aBDpxGhiNFvVZd9lrVVIoODsW+so7EmACLeHd0X4pLxK4FyklJzx?= =?us-ascii?Q?Pg8riTaoMmrU1ThGmmrVa0/SXkiplWzn0vbWSpgbHC3h1EyUEVaosp3B50ex?= =?us-ascii?Q?qRvacFK1TI+cxPJLo1kMKelDugrA5vSbOBjMP8l2fWN3s2WNJJ5h389FFKA2?= =?us-ascii?Q?Q7MH/6rZ5QHHazpEI7QKdaqZdObF/OmJmRwX68D27pQAKYRyOHu4CI3OrHlg?= =?us-ascii?Q?LLC7r2rv4vHLDIYgC8QlukfhvYgsoDaBK9cz4jut5fIM/3+YTG2tyyucuc2i?= =?us-ascii?Q?xc8iDtKbW4nPYc+ieE4nmYQkIb193TKdPETfY5ojaONAaQyFUCwITeFr5tY8?= =?us-ascii?Q?eHz0b5sHbE5QSZC7tvksU06n0v2lpRosrDXoQzNSz2+7aZEGKl5EhbL+ziSh?= =?us-ascii?Q?fhjBWJmyTmcUeH1sMYwxFt9xYkErE+EyTTJDrUquM4lauJe5gozVEN1pjpPp?= =?us-ascii?Q?LlDAR9QruNtihVEI7R/NFtMHrGGI0/Z1jvwnYJCA0TYmExq7hfhIyfDSVwLz?= =?us-ascii?Q?Rl6jEtS8GoSOpB2wQoHjcddZe86VzyUSkvoiTtzNtFEFta5qhW5EZ+xdfOW0?= =?us-ascii?Q?PlMmV8l5inIWPsY+jK/CJNgnwtbJdyHj2y6ai5UYULfVlm9xRufVbANS53bt?= =?us-ascii?Q?9MH4qTyp3CLsxx3Kn/pKhCeTX19Asbp6JooYVQ56jKPdVPQ25WwYu/cURJFt?= =?us-ascii?Q?Wg73Tuq/Z2q4tQtWHcGFRbwxgwcN7UU/n7EY/V9K7+W3tG3AaHSYsbtRPuRF?= =?us-ascii?Q?HONj3IbgIK53PeoA100h7USW7Gr3DVj463keKX06oFv6gqSrQzde/J5dVA0U?= =?us-ascii?Q?L9X0snCKL7HMYHtfADCQBeNmtm2J6RblcLdZptvufGf9XbG5gaTofyQExgpO?= =?us-ascii?Q?LuGb9WiZ1PIA=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1614;5:3XoLXWGup+nBedr0cRVwajdGRcQRJSTwBbGKQvKdcGTCHHLKZbXNkzA+dpvNBSU53PNHPoZRt77/obvRV89/PkGekKtrz66uy4gWkQQH/bD2yqTerkBL3G+WZJDA05xYWeUBVJl4YQATW6eg0TV33w==;24:sbPWoXOWdqWI78Hg0P8IIVp9S4+DdKxRY6K9OqJSxNNTmKiZam3RVw8TpXVKm6qAg15RFERwK8ZgEZ+FDrfOLSf2JUK0wyz2I0MHq59Xyuw= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2016 10:26:57.1507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1614 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.01.16 17:39:27, Hanjun Guo wrote: > From: Hanjun Guo > > After the cleanup for acpi_numa_memory_affinity_init(), > it can be used for architetures both x86 and arm64, since > CONFIG_MEMORY_HOTPLUG is not enabled for arm64, so no > worry about that. > > Signed-off-by: Hanjun Guo > --- > arch/arm64/kernel/acpi_numa.c | 42 ------------------------------- > arch/x86/mm/srat.c | 54 ---------------------------------------- > drivers/acpi/numa.c | 57 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 57 insertions(+), 96 deletions(-) This one reverts acpi_numa_memory_affinity_init() to the x86 version. I rather would prefer the arm64 version for the generic code. We could keep the x86 implementation until x86 maintainers agree to remove them and use the generic one (implemented in a separate patch). Doing so we can move acpi_numa_memory_affinity_init() from the beginning to generic code (used for arm64) and have this last patch to remove the x86 version. -Robert