From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756720AbcAYL3n (ORCPT ); Mon, 25 Jan 2016 06:29:43 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33078 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755727AbcAYL3l (ORCPT ); Mon, 25 Jan 2016 06:29:41 -0500 Date: Mon, 25 Jan 2016 11:29:36 +0000 From: Lee Jones To: Laxman Dewangan Cc: Krzysztof Kozlowski , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, vreddytalla@nvidia.com, Chaitanya Bandi , Mallikarjun Kasoju Subject: Re: [PATCH V4 2/5] mfd: max77620: add core driver for MAX77620/MAX20024 Message-ID: <20160125112936.GB3368@x1> References: <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-3-git-send-email-ldewangan@nvidia.com> <569F199D.9020207@samsung.com> <56A214EB.30905@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56A214EB.30905@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Jan 2016, Laxman Dewangan wrote: > Thanks Krzysztof for review. > > Hi Lee, > Are you taking the patches from your tree? Or will go in individual > subsystem? I can take the set if there are build dependencies. If there aren't, then they should be routed via their respective subsystem trees. > On Wednesday 20 January 2016 10:52 AM, Krzysztof Kozlowski wrote: > >On 19.01.2016 19:19, Laxman Dewangan wrote: > >>MAX77620/MAX20024 are Power Management IC from the MAXIM. > >>It supports RTC, multiple GPIOs, multiple DCDC and LDOs, > >>watchdog, clock etc. > >> > >>Add MFD drier to provides common support for accessing the > >>device; additional drivers is developed on respected subsystem > >>in order to use the functionality of the device. > >> > >>Signed-off-by: Laxman Dewangan > >>Signed-off-by: Chaitanya Bandi > >>Signed-off-by: Mallikarjun Kasoju > >>--- > >>Changes from V1: > >>- Code cleanups per review from V1. > >>- Move register acccess APIs from header to c file. > >>- Remove some of non required variable, remove duplication in error message > >> and simplify some of function implementation. > >>- Register RTC driver such that it can get the regmap handle form parent device > >> > >>Changes from V2: > >>- Run coccicheck and checkpatch in strict mode for the alignment. > >>- Drop RTC driver and its i2c client registration. > >> > >>Changes from V3: > >>- Change all sys initcall to module driver. > >>- change the max77620_read argument to unisgned int from u8. > >> > >> drivers/mfd/Kconfig | 15 + > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/max77620.c | 871 +++++++++++++++++++++++++++++++++++++++++++ > >> include/linux/mfd/max77620.h | 404 ++++++++++++++++++++ > >> 4 files changed, 1291 insertions(+) > >> create mode 100644 drivers/mfd/max77620.c > >> create mode 100644 include/linux/mfd/max77620.h > >> > > > >Reviewed-by: Krzysztof Kozlowski > > > >Best regards, > >Krzysztof > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog