From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757098AbcAYL4v (ORCPT ); Mon, 25 Jan 2016 06:56:51 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33986 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757007AbcAYL4l (ORCPT ); Mon, 25 Jan 2016 06:56:41 -0500 Date: Mon, 25 Jan 2016 11:56:37 +0000 From: Lee Jones To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Mika Westerberg Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path Message-ID: <20160125115637.GD3368@x1> References: <1453474126-128047-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453474126-128047-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Jan 2016, Andy Shevchenko wrote: > We forgot to remove the clock tree if something goes wrong in ->probe(). Add a > call to intel_lpss_unregister_clock() on error path in ->probe() to fix the > potential issue. > > Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices) > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel-lpss.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c > index 2a7c6a7..807a3e3 100644 > --- a/drivers/mfd/intel-lpss.c > +++ b/drivers/mfd/intel-lpss.c > @@ -455,6 +455,7 @@ int intel_lpss_probe(struct device *dev, > err_remove_ltr: > intel_lpss_debugfs_remove(lpss); > intel_lpss_ltr_hide(lpss); > + intel_lpss_unregister_clock(lpss); > > err_clk_register: > ida_simple_remove(&intel_lpss_devid_ida, lpss->devid); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog