* [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path
@ 2016-01-22 14:48 Andy Shevchenko
2016-01-25 10:57 ` Mika Westerberg
2016-01-25 11:56 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2016-01-22 14:48 UTC (permalink / raw)
To: linux-kernel, Lee Jones, Mika Westerberg; +Cc: Andy Shevchenko
We forgot to remove the clock tree if something goes wrong in ->probe(). Add a
call to intel_lpss_unregister_clock() on error path in ->probe() to fix the
potential issue.
Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/intel-lpss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 2a7c6a7..807a3e3 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -455,6 +455,7 @@ int intel_lpss_probe(struct device *dev,
err_remove_ltr:
intel_lpss_debugfs_remove(lpss);
intel_lpss_ltr_hide(lpss);
+ intel_lpss_unregister_clock(lpss);
err_clk_register:
ida_simple_remove(&intel_lpss_devid_ida, lpss->devid);
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path
2016-01-22 14:48 [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path Andy Shevchenko
@ 2016-01-25 10:57 ` Mika Westerberg
2016-01-25 11:56 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2016-01-25 10:57 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, Lee Jones
On Fri, Jan 22, 2016 at 04:48:46PM +0200, Andy Shevchenko wrote:
> We forgot to remove the clock tree if something goes wrong in ->probe(). Add a
> call to intel_lpss_unregister_clock() on error path in ->probe() to fix the
> potential issue.
>
> Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices)
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path
2016-01-22 14:48 [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path Andy Shevchenko
2016-01-25 10:57 ` Mika Westerberg
@ 2016-01-25 11:56 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2016-01-25 11:56 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, Mika Westerberg
On Fri, 22 Jan 2016, Andy Shevchenko wrote:
> We forgot to remove the clock tree if something goes wrong in ->probe(). Add a
> call to intel_lpss_unregister_clock() on error path in ->probe() to fix the
> potential issue.
>
> Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices)
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel-lpss.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
> index 2a7c6a7..807a3e3 100644
> --- a/drivers/mfd/intel-lpss.c
> +++ b/drivers/mfd/intel-lpss.c
> @@ -455,6 +455,7 @@ int intel_lpss_probe(struct device *dev,
> err_remove_ltr:
> intel_lpss_debugfs_remove(lpss);
> intel_lpss_ltr_hide(lpss);
> + intel_lpss_unregister_clock(lpss);
>
> err_clk_register:
> ida_simple_remove(&intel_lpss_devid_ida, lpss->devid);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-25 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-22 14:48 [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path Andy Shevchenko
2016-01-25 10:57 ` Mika Westerberg
2016-01-25 11:56 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox