From: Johan Hovold <johan@kernel.org>
To: Mathieu OTHACEHE <m.othacehe@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data
Date: Mon, 25 Jan 2016 13:01:59 +0100 [thread overview]
Message-ID: <20160125120159.GI3163@localhost> (raw)
In-Reply-To: <1451933379-21994-2-git-send-email-m.othacehe@gmail.com>
On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote:
> On nominal execution, private data allocated on port_probe and attach
> are never freed. Add port_remove and release callbacks to free them
> respectively.
>
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
I've applied this one for 4.5-rc2 now.
I want to take a closer look at the last three patches and it seems they
should wait for 4.6 anyway. I did notice that the vendor driver also
sends double START/OPEN commands at open by the way. Perhaps ask Moxa
why that is before we remove them?
Thanks,
Johan
next prev parent reply other threads:[~2016-01-25 12:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 18:49 [PATCH v2 0/4] USB: mxu11x0: fixes and follow ups Mathieu OTHACEHE
2016-01-04 18:49 ` [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data Mathieu OTHACEHE
2016-01-25 12:01 ` Johan Hovold [this message]
2016-01-30 17:40 ` Mathieu OTHACEHE
2016-02-28 12:20 ` Johan Hovold
2016-02-28 16:30 ` Mathieu OTHACEHE
2016-02-29 9:38 ` Johan Hovold
2016-01-04 18:49 ` [PATCH v2 2/4] USB: mxu11x0: clean device control commands Mathieu OTHACEHE
2016-01-04 18:49 ` [PATCH v2 3/4] USB: mxu11x0: remove duplicated set_termios call Mathieu OTHACEHE
2016-01-04 18:49 ` [PATCH v2 4/4] USB: mxu11x0: move firmware download and endpoint testing to probe callback Mathieu OTHACEHE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125120159.GI3163@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox