From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932720AbcAYMCY (ORCPT ); Mon, 25 Jan 2016 07:02:24 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36657 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932105AbcAYMB7 (ORCPT ); Mon, 25 Jan 2016 07:01:59 -0500 Date: Mon, 25 Jan 2016 13:01:59 +0100 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data Message-ID: <20160125120159.GI3163@localhost> References: <1451933379-21994-1-git-send-email-m.othacehe@gmail.com> <1451933379-21994-2-git-send-email-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451933379-21994-2-git-send-email-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote: > On nominal execution, private data allocated on port_probe and attach > are never freed. Add port_remove and release callbacks to free them > respectively. > > Signed-off-by: Mathieu OTHACEHE I've applied this one for 4.5-rc2 now. I want to take a closer look at the last three patches and it seems they should wait for 4.6 anyway. I did notice that the vendor driver also sends double START/OPEN commands at open by the way. Perhaps ask Moxa why that is before we remove them? Thanks, Johan