From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932551AbcAYMeT (ORCPT ); Mon, 25 Jan 2016 07:34:19 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:36509 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932486AbcAYMeR (ORCPT ); Mon, 25 Jan 2016 07:34:17 -0500 Date: Mon, 25 Jan 2016 13:34:12 +0100 From: Thierry Reding To: Rhyland Klein Cc: Peter De Schrijver , Mike Turquette , Stephen Warren , Stephen Boyd , Alexandre Courbot , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch V2 2/9] clk: tegra210: Remove improper flags for lock_enable Message-ID: <20160125123412.GE20452@ulmo.nvidia.com> References: <1452799478-14791-1-git-send-email-rklein@nvidia.com> <1452799478-14791-3-git-send-email-rklein@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ffoCPvUAPMgSXi6H" Content-Disposition: inline In-Reply-To: <1452799478-14791-3-git-send-email-rklein@nvidia.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ffoCPvUAPMgSXi6H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 14, 2016 at 02:24:31PM -0500, Rhyland Klein wrote: > Most PLL's don't actually have LOCK_ENABLE bits. However, most PLL's > also had that flag set, which meant that the clk code was trying to > enable locks, and inadvertantly flipping bits in other fields. >=20 > For PLLM, ensure the correct register is used for the misc_register. > PLL_MISC0 contains the EN_LCKDET bit which should be used for enabling > the lock, and PLLM_MISC1 shouldn't be used at all. >=20 > Lastly, remove some of the settings which would point to the EN_LCKDET > bits for some PLLs. There is no need to enable the locks, and that is > done as part of the set_defaults logic already. >=20 > Signed-off-by: Rhyland Klein > --- > drivers/clk/tegra/clk-tegra210.c | 42 ++++++++++++++--------------------= ------ > 1 file changed, 14 insertions(+), 28 deletions(-) It seems like this could've been split into several patches given the three different changes above. However since they all seem to relate to the lock enable behaviour I've gone and applied this as is. Thierry --ffoCPvUAPMgSXi6H Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWphZEAAoJEN0jrNd/PrOhppkP/1l+BZDc28KuhziBSZOdb78Z XPladFFOulXksTGqP9ian9vVpfdcFL9iAS3s+eVF5wDyJwVcjwEAihs2hJKrjogh WUgIGjUksbg3amFoXDc6MZbGfHp/mZUCDd/qU4/Dk5q5iJugMA2KB8RGmgRXR67v iSboVwMxEfxf/oAWTBRxNuo/F+9JMqxZ9G8oiBfIiFCocAu+joWzgtfkAgCc8pX4 BrvgWHwkON8TKswiIpFVoYOUGiQww8wAtnCHyGKHAOUgxCMeU6OIQEHpVMaAcdVa 9oejrjbG5laQlpZ/g6qTWZDTwdWmzEWQi0JNbHexWlekE5NT7xrnHDAMIPBGlKi5 zMOabFFv5lRZGc8RYwqY+ugS0SfOvqIs1dzccbC6wxiATRXYGg1X5/MdtVQDnB01 4NniX48fCOzW3rD8bjyiS3oq0wI8nSo0peyuvvAOEln3prM8EtlKkxFuibY7yksf /11Gu8Rya4OkskwrQsTFfICSWoZpjqFT9bzJFKDHF0ujEKJ7pwf+SHXiX0IbUQUt rgAwmWzgpuw9ZTohkhSzVycZNNZDrKYSkga1Pb0D5yNk9NkQhD7E99AaW6HOsjPt zS5x+g0ixnNKfW/nTwCi/blaWKqT9WMZgviEu8sXyPXwpiMWb68r/Mtw4vHqYiz8 h7emxlcvWm+VxjsJ92vP =a2KY -----END PGP SIGNATURE----- --ffoCPvUAPMgSXi6H--