From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932602AbcAYMyG (ORCPT ); Mon, 25 Jan 2016 07:54:06 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35074 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932102AbcAYMyB (ORCPT ); Mon, 25 Jan 2016 07:54:01 -0500 Date: Mon, 25 Jan 2016 12:53:56 +0000 From: Lee Jones To: Chen Feng Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, yudongbin@hisilicon.com, saberlily.xia@hisilicon.com, suzhuangluan@hisilicon.com, kong.kongxinwei@hisilicon.com, xuyiping@hisilicon.com, z.liuxinliang@hisilicon.com, puck.chenfeng@gmail.com, weidong2@hisilicon.com, w.f@huawei.com, qijiwen@hisilicon.com, peter.panshilin@hisilicon.com, dan.zhao@hisilicon.com, linuxarm@huawei.com, liguozhu@hisilicon.com Subject: Re: [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC Message-ID: <20160125125356.GO3368@x1> References: <1452514817-118311-1-git-send-email-puck.chen@hisilicon.com> <1452514817-118311-2-git-send-email-puck.chen@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1452514817-118311-2-git-send-email-puck.chen@hisilicon.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jan 2016, Chen Feng wrote: > Add document for mfd driver hi655x pmic driver > > Signed-off-by: Chen Feng > Signed-off-by: Fei Wang > Signed-off-by: Xinwei Kong > --- > .../devicetree/bindings/mfd/hisilicon,hi655x.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt > > diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt > new file mode 100644 > index 0000000..3180c40 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt > @@ -0,0 +1,28 @@ > +Hisilicon hi655x Power Management Integrated Circuit (PMIC) > + > +The hardware layout for access PMIC Hi655x from AP SoC Hi6220. > +Between PMIC Hi655x and Hi6220, the physical signal channel is SSI. > +We can use memory-mapped I/O to communicate. > + > ++----------------+ +-------------+ > +| | | | > +| Hi6220 | SSI bus | Hi655x | > +| |-------------| | > +| |(REGMAP_MMIO)| | > ++----------------+ +-------------+ > + > +Required properties: > +- compatible: Should be "hisilicon,hi655x-pmic" > +- reg: Base address of PMIC on hi6220 soc SoC > +- interrupt-controller: Hi655x has internal IRQs (has own IRQ domain). > +- pmic-gpios: The gpio used by pmic irq. PMIC IRQ > + > +Example: > + pmic: pmic@f8000000 { > + compatible = "hisilicon,hi655x-pmic"; > + reg = <0x0 0xf8000000 0x0 0x1000>; > + #interrupt-cells = <2>; > + interrupt-controller; > + pmic-gpios = <&gpio1 2 0>; What's the last cell for here? If they are flags, there is probably a #define you can use in dt-include. > + status = "disabled"; What's the point in disabling example code? > + } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog