From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933939AbcAYVcJ (ORCPT ); Mon, 25 Jan 2016 16:32:09 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60336 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933451AbcAYVcG (ORCPT ); Mon, 25 Jan 2016 16:32:06 -0500 Date: Mon, 25 Jan 2016 13:32:05 -0800 From: Andrew Morton To: Sasha Levin Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, oleg@redhat.com, peterz@infradead.org Subject: Re: [PATCH] signals: work around random wakeups in sigsuspend() Message-Id: <20160125133205.36542c86ada93761d8a9ff06@linux-foundation.org> In-Reply-To: <1453735306-13519-1-git-send-email-sasha.levin@oracle.com> References: <1453735306-13519-1-git-send-email-sasha.levin@oracle.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jan 2016 10:21:46 -0500 Sasha Levin wrote: > A random wakeup can get us out of sigsuspend() without TIF_SIGPENDING > being set. > > Avoid that by making sure we were signaled, like sys_pause() does. What we're lacking here is any description of the end-user-visible effects of the bug. Enough for people to be able to decide (and to recognize!) whether their kernel needs this patch.