From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757221AbcAYOia (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 09:38:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44356 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756637AbcAYOhq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 09:37:46 -0500
Date: Mon, 25 Jan 2016 15:37:43 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC 00/26] perf tools: Introduce hists specific format entries
Message-ID: <20160125143743.GA10064@krava.brq.redhat.com>
References: <1453109064-1026-1-git-send-email-jolsa@kernel.org>
 <20160125071552.GB23869@krava.brq.redhat.com>
 <20160125142424.GA7794@danjae.kornet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160125142424.GA7794@danjae.kornet>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 25, 2016 at 11:24:24PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> On Mon, Jan 25, 2016 at 08:15:52AM +0100, Jiri Olsa wrote:
> > On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> > > hi,
> > > currently we have global format sort and output
> > > lists. This rfc patchset introduces hists object
> > > based format entries to allow the hist object to
> > > carry specific format entries.
> > > 
> > > This will allow to have distinguished hist objects
> > > displaying different stuff in output.
> 
> The concepth is OK.  But I don't want to embed hists into the
> hist_entry for hierarchy mode.  As you said it'd be better to factor
> out common bits and embed it both from hists and hist entry.  In the
> minimal, two rbroot (for in and out) and a format list would be
> required IMHO.

right.. however this patchset just adds the support to have
format lists (sort and output) defined for the hists object

I plan the 'cutting out common hists' part to come after this
one and after we merge your hierachy view patchset

thanks,
jirka