From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757453AbcAYPJj (ORCPT ); Mon, 25 Jan 2016 10:09:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57037 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755543AbcAYPJg (ORCPT ); Mon, 25 Jan 2016 10:09:36 -0500 Date: Mon, 25 Jan 2016 16:09:33 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH 14/26] perf tools: Introduce struct perf_hpp_list Message-ID: <20160125150933.GA3251@krava.brq.redhat.com> References: <1453109064-1026-1-git-send-email-jolsa@kernel.org> <1453109064-1026-15-git-send-email-jolsa@kernel.org> <20160125150046.GB7794@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160125150046.GB7794@danjae.kornet> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 12:00:46AM +0900, Namhyung Kim wrote: SNIP > > void perf_hpp__cancel_cumulate(void) > > diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h > > index f3bcf2d38733..a9c8ccfcc284 100644 > > --- a/tools/perf/util/hist.h > > +++ b/tools/perf/util/hist.h > > @@ -226,20 +226,24 @@ struct perf_hpp_fmt { > > int idx; > > }; > > > > -extern struct list_head perf_hpp__list; > > -extern struct list_head perf_hpp__sort_list; > > +struct perf_hpp_list { > > + struct list_head list; > > + struct list_head sort_list; > > +}; > > What about this? > > struct perf_hpp_list { > struct list_head fields; > struct list_head sorts; > }; > > This also aligns with the option names. yep, sounds better ;-) thanks, jirka