From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932723AbcAYPUr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 10:20:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58898 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932120AbcAYPUp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 10:20:45 -0500
Date: Mon, 25 Jan 2016 16:20:41 +0100
From: Radim =?utf-8?Q?Krcm=C3=A1r?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Wu, Feng" <feng.wu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] KVM: x86: Use vector-hashing to deliver
 lowest-priority interrupts
Message-ID: <20160125152040.GC21252@potion.brq.redhat.com>
References: <1453254177-103002-1-git-send-email-feng.wu@intel.com>
 <1453254177-103002-3-git-send-email-feng.wu@intel.com>
 <20160121194950.GC17514@potion.brq.redhat.com>
 <E959C4978C3B6342920538CF579893F00C2C1C3B@SHSMSX104.ccr.corp.intel.com>
 <20160122140154.GD14104@potion.brq.redhat.com>
 <56A61432.3010500@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56A61432.3010500@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-01-25 13:25+0100, Paolo Bonzini:
> On 22/01/2016 15:01, Radim Krcmár wrote:
>>>         for (i = 0; i <= mod; i++) {
>>>                 idx = find_next_bit(bitmap, bitmap_size, idx + 1);
>>>                 BUG_ON(idx == bitmap_size);
>>>         }
> 
> WARN_ON, not BUG_ON.

Callers don't check the return value for an error, because every error
is a BUG now.  I think that we should check if we return bitmap_size.
(Current paths could dereference NULL or throw unrelated warnings.)

Also, WARN_ON_ONCE?