From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757399AbcAYPi2 (ORCPT ); Mon, 25 Jan 2016 10:38:28 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33426 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbcAYPiL (ORCPT ); Mon, 25 Jan 2016 10:38:11 -0500 Date: Mon, 25 Jan 2016 16:38:19 +0100 From: Daniel Vetter To: Andreas Ziegler Cc: chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Message-ID: <20160125153819.GL11240@phenom.ffwll.local> Mail-Followup-To: Andreas Ziegler , chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter References: <20160125112608.GF10520@nuc-i3427.alporthouse.com> <1453722079-2604-1-git-send-email-andreas.ziegler@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453722079-2604-1-git-send-email-andreas.ziegler@fau.de> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2016 at 12:41:19PM +0100, Andreas Ziegler wrote: > Commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access > through GGTT on Braswell") depended upon a working stop_machine() and > so forced the selection of STOP_MACHINE. However, commit 86fffe4a61dd > ("kernel: remove stop_machine() Kconfig dependency") removed the option > STOP_MACHINE from init/Kconfig and ensured that stop_machine() > universally works. Due to the order in which the patches were applied, > removing the select from DRM_I915 got lost during merging. > > Remove the now obsolete select statement. > > Signed-off-by: Andreas Ziegler > Reviewed-by: Chris Wilson Applied, thanks. -Daniel > --- > Changes to v1: > - Tell the story right, suggested by Chris Wilson > > drivers/gpu/drm/i915/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index fcd77b2..051eab3 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -10,7 +10,6 @@ config DRM_I915 > # the shmem_readpage() which depends upon tmpfs > select SHMEM > select TMPFS > - select STOP_MACHINE > select DRM_KMS_HELPER > select DRM_PANEL > select DRM_MIPI_DSI > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch