From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757435AbcAYPnk (ORCPT ); Mon, 25 Jan 2016 10:43:40 -0500 Received: from mail-by2on0068.outbound.protection.outlook.com ([207.46.100.68]:39456 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752265AbcAYPna (ORCPT ); Mon, 25 Jan 2016 10:43:30 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O1IMCB-08-GBN-02 X-M-MSG: Date: Mon, 25 Jan 2016 23:43:41 +0800 From: Huang Rui To: Peter Zijlstra CC: Borislav Petkov , Ingo Molnar , "Andy Lutomirski" , Thomas Gleixner , Robert Richter , Jacob Shin , "John Stultz" , =?utf-8?B?RnLvv71k77+9cmlj?= Weisbecker , , , , Guenter Roeck , Andreas Herrmann , Suravee Suthikulpanit , Aravind Gopalakrishnan , Borislav Petkov , "Fengguang Wu" , Aaron Lu Subject: Re: [PATCH v3] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Message-ID: <20160125154340.GE16975@hr-amur2> References: <1453710723-1616-1-git-send-email-ray.huang@amd.com> <20160125111305.GU6357@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160125111305.GU6357@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(189002)(164054003)(24454002)(199003)(4326007)(50466002)(87936001)(97756001)(2906002)(83506001)(92566002)(86362001)(33716001)(46406003)(23726003)(110136002)(1220700001)(1096002)(77096005)(11100500001)(54356999)(2950100001)(106466001)(1076002)(97736004)(33656002)(4001350100001)(189998001)(101416001)(47776003)(50986999)(105586002)(586003)(5008740100001)(76176999)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0713;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0713;2:mV7SDe9Biq41m7xJ5OZWtmVale/HgODIkrzmRDWf6fTMnz4NjAhgAiG/f5FkugbG4MMz03Tp0jxzZ0QQK0onCkP035BThtYzMY3LefFQXqePW3Xn8o8we0DV59uuRKCCwIl9WVcqMCUWg6l6VuoaEA==;3:BKMczYuaibbi5v1qCVgSanZE6116FYCJ/CAEV1pWY0R0TdXHl15Psml6DIBHjSyRzetmyzNiAgU1oma5eWBCDvq16lVCVZaUQq5QYNOzaolhEpbi56pavb0r3lJRpJQ1CjoS84+QgOQ9rXFg6vgOvWMXZqJNpBUQOWsZLp/wAzRallZwM/QATg8HuJoZXo61NwheNJMMSxp1cTXhHjt65+JMg7eUFPo4RDRTX+kJy0U=;25:C4amXpjopz0u8MjUM2BA2eDIELeC5knd/57GAeVLyxBx5SngoLEoYr+2xjYI35kSOD5eKMLslPYaSZIYNNQKq7+MsE4W/pbZMbnWv8lbxnFqv3pwTGg6AmtlzGF1CG2E+X6laY+p/uXqoJ+7gu6CCWASTygrYYNYuQaDKa5GUWcAc3uLcmmxPlE8CiRUQAlSb27vVFSAsfAMRr8dYWPdyLJFZ12JZDJgkszUNpmXeXElVgBuuk1CF1HxNTphyg9G X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0713; X-MS-Office365-Filtering-Correlation-Id: 922c76c6-16f0-4eff-d129-08d3259e44cf X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0713;20:wKPy/WUA/wa7BbkFq5pKHcmVkYU+IxIMA0T7osbnETyL4BYZm31Oro6q57qYE0GClLHreHYO8WXEX6mzQUVf+I8M4duBSCIJVUqCve47QkF4if5iACb/WqIVp7u6nTMd/3pehUUkfb/DOOvAkShfQspnBHnYP3tk5pM86mh4WeVXi1WRyTGYShtuMTfzaYIyfXkRP91+nHuAbzVR+nJ/G3SEVJUdPzJfQE1q8AP6QBybAdO29/WlFdVJwqLXmjWVPuY/nT5YTDireYJkpHEg3XfjHkeKK4aj092bxCA+3xNDGgqGGlnT31Y5zFAN/mgRkTjwnVqIm9Ed58bErYLyhyt7pf/JpkIqlxRrOjN1IMkhY5Grt0jNHl2w67QaFELS0p9LUfeb1AO0A7SD0jfwKDpqfSAsDjLcLyrPvnhWlN9HvN1foHJNV/eFToI0MWYqYH2Jzs/5awShDgNTNRdKnHhpYa1CNPXVAGAnms+Q6LwLcB1KJk68AHp1YkBUUbO4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(123027)(601004)(2401047)(8121501046)(13015025)(13017025)(13024025)(13023025)(5005006)(520078)(13018025)(10201501046)(3002001);SRVR:CY1PR12MB0713;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0713; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0713;4:TAbshwkrD6GElstyA+QArG9eeQwodJc3BtGjvzBOHAHvwg4yFN3X+aspnYFqNU9nV2wMJuFdaj5cKNrrVqr6knIwF2rXB6Gn/03oJ/PI/0EIF33Z0GIpP4bWZnIA7cDIZE52GP/Le0v3gm+W28Kg17F3SKtxulyeEgi1zJBjFzYR5JLWRcNqew4CWarbrp2DpkSqxZJBf4C7/2C2yRjekJnwBkfRYHAJ8x2hoez3A53uWM53m8EC6fdoZ5PoGEsDEnRG1+WxNuxVwBDsg7sAwBC8qmdgYUCa75hurJbGwURRQ0xgJq5SBN7XIQOECLOkHFwod52VgcGp6t5Gf4NIhTGNECXUxES8Ewj5+eOremZNfgy5bjNpn1gHjXnEncroWWpDlisC+rM6r4xQK/gtgwsYljfcTGfWSoKLS0Z9Ad5LJpoWmaDwOAGdN3NkZZSn9LsOBSeM4roliF+Aoep2OHqt6KQXlcIYIIAOiEcxsU2Dyhh1gBqmjTl26fDOVDXP X-Forefront-PRVS: 083289FD26 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR12MB0713;23:ZQOtyjPvAD22SpeiQole/y2GrY8OZmJW9V/sca9Fk?= =?us-ascii?Q?Cama56U1k8mqz827PYJNQIIKGzgrfe8mWcOPYsk/kFBqi/+n0C43I6r5YMN1?= =?us-ascii?Q?2z8KX4cwuxGdPiMyihjKKtlsarycxYZIWVplPc7lgRkQzzbstSv2ra55g58a?= =?us-ascii?Q?55C1T138VufTYuTpgUw7odnYRDMz1szd4M6hQMbFOjyxuXRSqlWi6H0JeDrz?= =?us-ascii?Q?hsQ2RJ6jtR6yh/pTaFNmkAJwFHOR8LLkHYcfo6J/xf9L9DpeSCWHgRN4/URS?= =?us-ascii?Q?5eCTAlgEPv98AAiP8jntuY+ZHqZSrHi94SmYcmm5J+nYRqAHg94z7vnE9KGw?= =?us-ascii?Q?SFc85vCfFLp1UNwZk/NqlFoe7k5yWLO9/Jp9XXBoOj+Tc3VXFP1Tzo+ee74a?= =?us-ascii?Q?ak4U+2dQZJPwFKsjSyxWda2XwsoJh5csJqMTr+1bF7a56omOhF49tGlhw+8j?= =?us-ascii?Q?QYlqhIn6TDx18AY1yXY3RghhBL+nOEcBB8Pf5jhFz0otIGvDAmvag8GRPDQy?= =?us-ascii?Q?mTozGEMhszdDFnyy5GKT3vA317oXVs8ysZsHBVHCdPC7iegfCHKVkkctVIPW?= =?us-ascii?Q?8wwIzRL7esEbfokXwHrurCVAOYES0ZwW9znW58ujLlCD4lnj8omIIa7w5D3M?= =?us-ascii?Q?4CperdiZpm634SACdS4Eqet2NjyimwYXMaxULER38fk80WHiU4Kba651zn1i?= =?us-ascii?Q?6n9Z0RaYVnTCA+dEwaYIYR+KQ/C40xCyUgZvoEgy51yf8k6dDHEaToxdpHgw?= =?us-ascii?Q?YWp0x3IIsldnixLzXfnPQtexEFco6fHNrLqHZ0JskGupdEh6dp3E2J9brKYn?= =?us-ascii?Q?KMhPuaGHio3B4nevyvh3CfbJuEP8aLbeQ3gfP74sHREuc09Pzen2I4IiopkE?= =?us-ascii?Q?/7Nw7cJ+lAyzbE3ppzD2a3Cz0eaJ+Nvvw4yxfmDYktWOPxlXnFVspUW3qOyM?= =?us-ascii?Q?1bM+gqexE7tUS/j8DlQyIgGLWkZCbofYqIquWpCuGRMN66FqTb1p968eAUD0?= =?us-ascii?Q?qu+2xcN8Kd8/3h+FKDKi8pS?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0713;5:T4E4E09y+o62H6uXNdrtL0G+JX4vOfYSiiK9TsAeyrPnazuY/bvr64qNND9qENZLoO30ebGb0wCkbmJBQmirnaYU/P7z58EtjuD4Ucms/mPoj4CRUiYGRbDS0DV0kixkvNGRCheNMkcvb6niYyU0Mw==;24:mogPMR98k1U59q+8vd/Bbib/vXA8ipSuhZBa3Z1WMTYL3LNXVzlrxzJ2Enu7DlkciMrI6W79yhw6jGy5j5H8KHXoRO5mzkh0T5KgqbKwvmw=;20:pLDVJCoZaLA/A362is768PvpQfQYxJT+xTIUhBXz1EFnd/OReCb5n2uVN1l11qrpGYd9MrQ4UQxKsWF8GFwobhiuJgrZyVPR6/aWBd1OqiuBjMOPmfkkU5wN2/uJH1/bWXLXBmw+nKpMNA1E5saUku7FSTVRvbvTjP0LM87m8lLfu5SNH8mMYd2AXkvXDx19JU1Au/3zs9cEeyFbllZhxUsFJ3DRTako5jh8FLxKqPQr+5I6MczKz9+XpBs0L9i5 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2016 15:43:25.9683 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0713 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2016 at 12:13:05PM +0100, Peter Zijlstra wrote: > On Mon, Jan 25, 2016 at 04:32:03PM +0800, Huang Rui wrote: > > +struct power_pmu { > > + raw_spinlock_t lock; > > + struct list_head active_list; > > Maybe a dumb question, but what is that list for? > > You only ever add/del events to/from it, you never iterate it. So why > keep it? > > If you drop the list, the lock can go too I think, making all this stuff > simpler. Yes, the active_list seems a bit superfluous if not be iterated. I will remove it. Any other comments? :-) Thanks, Rui