From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Colin King <colin.king@canonical.com>
Cc: Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Ira Weiny <ira.weiny@intel.com>, Christoph Lameter <cl@linux.com>,
Matan Barak <matanb@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/sysfs: remove unused va_list args
Date: Mon, 25 Jan 2016 10:47:05 -0700 [thread overview]
Message-ID: <20160125174705.GA28108@obsidianresearch.com> (raw)
In-Reply-To: <1453742627-24698-1-git-send-email-colin.king@canonical.com>
On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Yep. This is bad new breakage too. Care to add a fixes line?
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Jason
next prev parent reply other threads:[~2016-01-25 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 17:23 [PATCH] IB/sysfs: remove unused va_list args Colin King
2016-01-25 17:47 ` Jason Gunthorpe [this message]
2016-01-25 18:28 ` ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125174705.GA28108@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=cl@linux.com \
--cc=colin.king@canonical.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox